Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use NumberProperty #257

Closed
pixelzoom opened this issue Jul 31, 2019 · 2 comments
Closed

use NumberProperty #257

pixelzoom opened this issue Jul 31, 2019 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

Related to code review #247

There are multiple places where Property should be replaced with NumberProperty. I count ~24. Search for "new Property" to locate them. This is especially important if this is a PhET-iO release.

For example, in Beaker:

      // @public {Property.<number>} - fluid level in beaker, should only be set in sub-types
      this.fluidLevelProperty = new Property( EFACConstants.INITIAL_FLUID_LEVEL );

      // @public (read-only) {Property.<number>} - temperature of fluid in beaker
      this.temperatureProperty = new Property( EFACConstants.ROOM_TEMPERATURE );
@chrisklus
Copy link
Contributor

Ready for review

@pixelzoom
Copy link
Contributor Author

👍 closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants