-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usability on small screens review #239
Comments
@chrisklus can you dilate the touch area for the FaucetNode handle a bit more? |
I have a very difficult time checking the energy symbols and link heaters checkboxes on my iPhone SE (smaller screen than any other current iPhone, so perhaps doesn't matter). |
@arouinfar how does this look? |
@arouinfar - What do you think about making these touch areas for the checkboxes bigger in any direction - so its easier to hit? Perhaps the checkboxes could have a bit more vertical padding/space. |
Looks good!
I can't remember if we added asymmetric touch area dilation to checkboxes or not, so perhaps @chrisklus can comment about whether this is currently supported or not. I think we could certainly add a bit more vertical padding between the checkboxes. Perhaps a few extra pixels @chrisklus? |
It doesn't look like we support this with the typical dilation options but I think I can pass in a custom touch area that has a pre-calculated size. I'll ask if this is the standard way for checkboxes. |
That is what's done for the usages I found, so I went ahead with this pattern. Per #239 (comment), I increased the padding between the two checkboxes by 2px, and dilated the touch areas by 5px on the top and bottom. Before: After: I dilated the "Energy Symbols" checkbox on the Systems screen as well. They are now much easier to select on my iPhone SE. Anything left for this issue @arouinfar? |
Nice, thanks @chrisklus! I think that takes care of everything, closing. |
Per @kathy-phet's request in phetsims/qa#295 I am making issues in each published sim repo detailing the pointer areas and usability of sims on phone sized screens. Done on an iPhone 7 iOS 12 device.
Potential Difficulties Noticed:
Screenshots:
The text was updated successfully, but these errors were encountered: