Add phetioVisiblePropertyInstrumented: true, see phetsims/scenery#1447

phetsims · Sep 16, 2022 · fe849ba · fe849ba
1 parent 68711b6
commit fe849ba
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/js/common/view/BeakerView.js b/js/common/view/BeakerView.js
@@ -188,7 +188,8 @@ class BeakerView extends PhetioObject {
     const labelText = new RichText( options.label, {
       font: LABEL_FONT,
       maxWidth: beakerBounds.width * 0.7, // empirically determined to look nice
-      tandem: options.tandem.createTandem( 'labelText' )
+      tandem: options.tandem.createTandem( 'labelText' ),
+      phetioVisiblePropertyInstrumented: true
     } );
 
     labelText.translation = new Vector2(

diff --git a/js/energy-forms-and-changes-phet-io-overrides.js b/js/energy-forms-and-changes-phet-io-overrides.js
@@ -70,16 +70,13 @@ window.phet.preloads.phetio.phetioElementsOverrides =
     "energyFormsAndChanges.introScreen.view.beakerProxyNodeGroup.archetype.labelText.stringProperty": {
       "phetioFeatured": true
     },
-    "energyFormsAndChanges.introScreen.view.beakerProxyNodeGroup.archetype.labelNode.visibleProperty": {
-      "phetioFeatured": true
-    },
-    "energyFormsAndChanges.introScreen.view.blockNodeGroup.archetype.labelNode.textProperty": {
+    "energyFormsAndChanges.introScreen.view.beakerProxyNodeGroup.archetype.labelText.visibleProperty": {
       "phetioFeatured": true
     },
     "energyFormsAndChanges.introScreen.view.blockNodeGroup.archetype.labelText.stringProperty": {
       "phetioFeatured": true
     },
-    "energyFormsAndChanges.introScreen.view.blockNodeGroup.archetype.labelNode.visibleProperty": {
+    "energyFormsAndChanges.introScreen.view.blockNodeGroup.archetype.labelText.visibleProperty": {
       "phetioFeatured": true
     },
     "energyFormsAndChanges.introScreen.view.controlPanel.visibleProperty": {
@@ -163,7 +160,7 @@ window.phet.preloads.phetio.phetioElementsOverrides =
     "energyFormsAndChanges.systemsScreen.view.energyConverters.generatorNode.labelText.stringProperty": {
       "phetioFeatured": true
     },
-    "energyFormsAndChanges.systemsScreen.view.energyConverters.generatorNode.labelNode.visibleProperty": {
+    "energyFormsAndChanges.systemsScreen.view.energyConverters.generatorNode.labelText.visibleProperty": {
       "phetioFeatured": true
     },
     "energyFormsAndChanges.systemsScreen.view.energySourceSelectorPanel.visibleProperty": {
@@ -196,7 +193,7 @@ window.phet.preloads.phetio.phetioElementsOverrides =
     "energyFormsAndChanges.systemsScreen.view.energyUsers.beakerHeaterNode.beakerProxyNode.labelText.stringProperty": {
       "phetioFeatured": true
     },
-    "energyFormsAndChanges.systemsScreen.view.energyUsers.beakerHeaterNode.beakerProxyNode.labelNode.visibleProperty": {
+    "energyFormsAndChanges.systemsScreen.view.energyUsers.beakerHeaterNode.beakerProxyNode.labelText.visibleProperty": {
       "phetioFeatured": true
     }
   };
diff --git a/js/intro/view/BlockNode.js b/js/intro/view/BlockNode.js
@@ -221,7 +221,8 @@ class BlockNode extends Node {
       maxWidth: modelViewTransform.modelToViewDeltaX( EFACConstants.BLOCK_SURFACE_WIDTH * 0.9 ),
       centerX: ( upperLeftFrontCorner.x + upperRightFrontCorner.x ) / 2,
       centerY: ( upperLeftFrontCorner.y + lowerLeftFrontCorner.y ) / 2,
-      tandem: options.tandem.createTandem( 'labelText' )
+      tandem: options.tandem.createTandem( 'labelText' ),
+      phetioVisiblePropertyInstrumented: true
     } );
     this.addChild( labelText );
 

diff --git a/js/systems/view/GeneratorNode.js b/js/systems/view/GeneratorNode.js
@@ -56,7 +56,8 @@ class GeneratorNode extends MoveFadeModelElementNode {
       centerX: generatorNode.centerX,
       bottom: generatorNode.bottom - 6,
       tandem: options.tandem.createTandem( 'labelText' ),
-      maxWidth: 160 // empirially determined
+      maxWidth: 160, // empirially determined
+      phetioVisiblePropertyInstrumented: true
     } );
     const spokesNode = new Image( generatorWheelSpokes_png, {
       centerX: generatorNode.centerX,