more reduction of bounds allocations, see #191

phetsims · Jan 24, 2019 · 263d112 · 263d112
1 parent f01ca06
commit 263d112
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/js/common/model/Beaker.js b/js/common/model/Beaker.js
@@ -223,12 +223,7 @@ define( function( require ) {
      * @public
      */
     getBounds: function() {
-      return this.beakerBounds.setMinMax(
-        this.positionProperty.value.x - this.width / 2,
-        this.positionProperty.value.y,
-        this.positionProperty.value.x + this.width / 2,
-        this.positionProperty.value.y + this.height
-      );
+      return this.compositeBounds;
     },
 
     /**

diff --git a/js/intro/model/Block.js b/js/intro/model/Block.js
@@ -187,8 +187,7 @@ define( function( require ) {
      * @public
      */
     getBounds: function() {
-      var rect = this.rect;
-      return new Bounds2( rect.x, rect.y, rect.x + rect.width, rect.y + rect.height );
+      return this.compositeBounds;
     },
 
     /**

diff --git a/js/intro/model/RectangularThermalMovableModelElement.js b/js/intro/model/RectangularThermalMovableModelElement.js
@@ -62,6 +62,7 @@ define( function( require ) {
     // @private {Bounds2} - composite bounds for this model element, maintained as position changes
     this.compositeBounds = Bounds2.NOTHING.copy();
 
+    // update the composite bounds as the model element moves
     this.positionProperty.link( function( position ) {
       self.compositeBounds.setMinMax(
         position.x - width / 2,