add inline REVIEW comments, #247

phetsims · Jul 31, 2019 · 034dc0d · 034dc0d
1 parent 8691c76
commit 034dc0d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 1 deletion.
diff --git a/js/common/model/TemperatureAndColorSensor.js b/js/common/model/TemperatureAndColorSensor.js
@@ -17,6 +17,7 @@ define( require => {
 
   class TemperatureAndColorSensor extends UserMovableModelElement {
 
+    //REVIEW #247 passing in the entire model is undesirable
     /**
      * @param {EFACIntroModel} model
      * @param {Vector2} initialPosition

diff --git a/js/common/view/PlayPauseStepButtonGroup.js b/js/common/view/PlayPauseStepButtonGroup.js
@@ -18,6 +18,7 @@ define( require => {
 
   class PlayPauseStepButtonGroup extends HBox {
 
+    //REVIEW #247 passing in the entire model is undesirable
     /**
      * @param {EFACIntroModel|SystemsModel} model
      */

diff --git a/js/intro/model/StickyTemperatureAndColorSensor.js b/js/intro/model/StickyTemperatureAndColorSensor.js
@@ -16,7 +16,7 @@ define( require => {
 
   class StickyTemperatureAndColorSensor extends TemperatureAndColorSensor {
 
-    //REVIEW #247 passing in model.blocks and model.beakers, not the entire model
+    //REVIEW #247 passing in the entire model is undesirable
     /**
      * @param {EFACIntroModel} model
      * @param {Vector2} initialPosition

diff --git a/js/intro/view/BeakerContainerView.js b/js/intro/view/BeakerContainerView.js
@@ -32,6 +32,7 @@ define( require => {
 
   class BeakerContainerView extends BeakerView {
 
+    //REVIEW #247 passing in the entire model is undesirable
   /**
    * @param {Beaker} beaker
    * @param {EFACIntroModel} model
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,6 +18,7 @@ define( require => { @@
       class PlayPauseStepButtonGroup extends HBox {
+        //REVIEW #247 passing in the entire model is undesirable
         /**
          * @param {EFACIntroModel|SystemsModel} model
          */
@@ Expand Down @@