Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group block sets in the tree and follow consistent naming patterns #96

Closed
arouinfar opened this issue Sep 3, 2021 · 2 comments
Closed

Comments

@arouinfar
Copy link
Contributor

arouinfar commented Sep 3, 2021

For #76

Currently, there is a lot of variability in how the blocks are named, such as blueMass, primaryMass, set1.1A. The sim view refers to these objects as "Blocks" so let's use that terminology for consistency. I think it would also be helpful to group the block sets together in the tree along with the property responsible for switching between the sets.

Here's a proposed tree structure. @jonathanolson please let me know if you have any concerns or questions.

introScreen
   model
       -blockSets
           blockSetProperty    //property connected to the RadioButtonGroup
           -sameDensity
                +blueBlock
                +greenBlock
                +redBlock
                +yellowBlock
           +sameMass    //use same pattern as above
           +sameVolume


exploreScreen
   model
      -blocks    //only two masses on this screen, so no "sets"
         +blockA    //formerly primaryMass
         +blockB    //formerly secondaryMass
   view
      +blockAControlPanel    //formerly primaryBlockControlNode
      +blockBControlPanel   //formerly secondaryBlockControlNode
      +blocksRadioButtonGroup   //formerly secondMassVisibleControl


mysteryScreen
   model
       -blockSets
           blockSetProperty    //property connected to the RadioButtonGroup
           -random
              +blockA
              +blockB
              +blockC
              +blockD
              +blockE
           -set1
              +block1A
              +block1B
              +block1C
              +block1D
              +block1E
           +set2   //use same pattern as above
           +set3

Edit: I forgot there were references to primary/secondaryMass in exploreScreen.view, so I updated the tree mockup above.

@jonathanolson
Copy link
Contributor

Implemented above, can you verify?

@arouinfar
Copy link
Contributor Author

Thanks @jonathanolson the tree structure looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants