-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metadata of several model properties #91
Comments
This will be a bit weird for phrasing in Buoyancy. Do we need to switch the documentation for things between the sims? |
Do you have any ideas for something that could work for both sims? It's preferable to keep the documentation the same, if possible. |
Implemented changes, can you verify?
I've used the word "mass" instead of "block", however that could be somewhat confusing with that phrase. |
What about the phrase "object" or "shape" instead of "mass". I do think "Displays a mass readout on each mass" will be hard to understand. |
Updated to "Displays a mass readout on each object" above. |
@jonathanolson I missed the scale in my first review. Please make all of the following
|
Implemented above, can you verify? |
Looks good, closing. |
For #76
Lots of model properties need some combination of phetioDocumentation and/or units.
density.*Screen.model.gravityProperty
density.*Screen.model.invisibleBarrierBoundsProperty
density.*Screen.model.liquidMaterialProperty
density.*Screen.model.liquidViscosityProperty
density.introScreen.model.showMassesProperty
density.*Screen.model.densityProperty
density.Screen.model.massProperty
density.introScreen.model.pool.liquidYInterpolatedProperty
density.*Screen.model.pool.liquidVolumeProperty
add phetioDocumentation
add units
For each block,
buoyancyForceInterpolatedProperty
,contactForceInterpolatedProperty
,gravityForceInterpolatedProperty
,massProperty
,materialProperty
(density/viscosity), andvolumeProperty
should have units.For each block,
buoyancyForceInterpolatedProperty
,contactForceInterpolatedProperty
,gravityForceInterpolatedProperty
should be phetioHighFrequency: trueAll instances of
inputEnabledProperty
should have this phetioDocumenation: Sets whether the element will have input enabled, and hence be interactive.The text was updated successfully, but these errors were encountered: