density.global.view.colorProfile should only contain colors relevant to Density

[arouinfar]

For #76

Several of the colors in the color profile only apply to the Buoyancy simulation. Can they be removed from Density @jonathanolson?

[jonathanolson]

@samreid or @zepumph, could we conditionally remove the display of color properties? Or would it be best to conditionally provide opt-out tandems?

[samreid]

How about DensityColors.js and BuoyancyColors.js?

[jonathanolson]

We still instantiate constant Materials on startup, and have a list of all Materials. Would I need to make color/material loading lazy? This could totally mess up state restoring.

[samreid]

Would it be easy to have a list of DensityMaterials and BuoyancyMaterials, or is it better to have them all defined together?

[jonathanolson]

It would be better to have them defined together.

[zepumph]

What about metadata on them that can be used to conditionally instrument? Or conditionally phetioFeature them depending on what sim is being run?

[zepumph]

What about using something like the namespace solution from phetsims/scenery#1259? Or will this not work because they are all defined in the common repo?

[zepumph]

Probably it will be best to just have a ternary on how you provide the Tandem, like for

https://github.com/phetsims/density-buoyancy-common/blob/6703af36f2c598358f2bdbbaa3def94d5198bfbd/js/common/view/DensityBuoyancyCommonColors.js#L110

. . . .

    tandem: DENSITY_IS_THE_SIM ? tandem.createTandem( 'mysteryOrangeColorProperty' ) : Tandem.OPT_OUT

[jonathanolson]

It looks like the ternary is working best. Committed above, @arouinfar can you verify?

[arouinfar]

Thanks @jonathanolson! The tree looks much better now.