Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several properties should be phetioReadOnly: true #79

Closed
9 tasks done
arouinfar opened this issue Aug 10, 2021 · 2 comments
Closed
9 tasks done

Several properties should be phetioReadOnly: true #79

arouinfar opened this issue Aug 10, 2021 · 2 comments
Assignees

Comments

@arouinfar
Copy link
Contributor

arouinfar commented Aug 10, 2021

For #76

These properties should be read-only, as there is no need for the client to directly set them.

  • density.*Screen.model.gravityProperty
  • density.*Screen.model.liquidMaterialProperty
  • density.*Screen.model.pool.liquidYInterpolatedProperty
  • density.*Screen.model.pool.liquidVolumeProperty

For each block:

  • buoyancyForceInterpolatedProperty
  • contactForceInterpolatedProperty
  • gravityForceInterpolatedProperty
  • sizeProperty
  • userControlledProperty
jonathanolson added a commit to phetsims/density-buoyancy-common that referenced this issue Aug 10, 2021
@jonathanolson
Copy link
Contributor

I believe these should all be handled with the above commit.

@arouinfar
Copy link
Contributor Author

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants