Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of global.model.materials #282

Closed
11 tasks done
arouinfar opened this issue Jul 26, 2024 · 4 comments
Closed
11 tasks done

Cleanup of global.model.materials #282

arouinfar opened this issue Jul 26, 2024 · 4 comments

Comments

@arouinfar
Copy link

arouinfar commented Jul 26, 2024

Related to phetsims/buoyancy#51.

I reviewed the updated materials for #250, and identified some needed cleanup.

  • Move sand to materials.solids
  • Rename mysteryY > materialY.
  • All non-custom, non-mystery materials should have a read-only density.
  • Uninstrument all materials that aren't user-selectable:
    • air
    • boatHull
    • diamond
    • glass
    • human
    • lead
    • titanium
  • Materials should only appear in the trees of relevant sims. (No non-water fluids in Density, for example.)

Over to @AgustinVallejo. Please let me know if you have any questions.

@AgustinVallejo
Copy link
Contributor

I believe this is done, back to @arouinfar to review.

@samreid
Copy link
Member

samreid commented Jul 31, 2024

Uninstrumenting the boat body caused the CT error which is also tracked in #301. I'll close that issue and address it here

@arouinfar
Copy link
Author

Overall, the changes look good. If I'm not mistaken, @samreid reinstrumented the boat's material, which in retrospect, seems like useful information for the clients. Thanks!

@samreid @AgustinVallejo can you please rename boatBody to boatHull? It was previously boatHull, which is the more appropriate terminology.

@AgustinVallejo
Copy link
Contributor

Renamed the tandem, closing. Also, thanks @samreid for fixing the CT issue! Didn't catch that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants