Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete canRotate #277

Closed
samreid opened this issue Jul 23, 2024 · 2 comments
Closed

Delete canRotate #277

samreid opened this issue Jul 23, 2024 · 2 comments

Comments

@samreid
Copy link
Member

samreid commented Jul 23, 2024

canRotate seems unused. Can we delete it?

@AgustinVallejo
Copy link
Contributor

Did this but would benefit from another pair of eyes. The code removal was pretty straightforward, but I had to change MassIO because it had a stateKey associated with canRotate. Added the following migration rule, and it seems to be congrulatory, but again, assigning back to @samreid for review:

    new ChangeStateKeyIOType( 'MassIO', 'tag', 'MassTagIO', mass => {
      delete mass.canRotate;
    } )

@AgustinVallejo AgustinVallejo assigned zepumph and unassigned samreid Jul 24, 2024
zepumph added a commit that referenced this issue Jul 25, 2024
Signed-off-by: Michael Kauzmann <[email protected]>
@zepumph
Copy link
Member

zepumph commented Jul 25, 2024

Looks great, thanks.

@zepumph zepumph closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants