-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are secondaryMassVisibleProperty
and secondaryMass.visibleProperty
redundant?
#25
Comments
I think this ends up being a phet-io design question. After the recent refactoring to add |
On the surface, In Density and Buoyancy, there are some screens where there are several blocks always present in the play area, such as Would it be possible/reasonable to hook up the one vs. two block RadioButtonGroup to |
Tagging phetsims/density#76 since it's relevant to the PhET-iO design review. |
Handled this for everything except Buoyancy's Shapes screen (which will probably need phet-io design on its own). @arouinfar how does this look? @samreid does this satisfy your concern? |
Yes, the code change looks good. @arouinfar please close if the design is satisfactory. |
Looks good to me, thanks @jonathanolson |
During code review #5, I saw this code in DensityExploreModel:
Do we need both properties? If so, please explain how they are different and why it is important to have both.
The text was updated successfully, but these errors were encountered: