-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does the html file size seem reasonable, compared to other similar sims? #172
Comments
Self assigning to see why density went from 4MB to 15.6MB |
The density-buoyancy-common/images/*.ts files take up 12.2MB before compression. |
I tried running
|
I found the instructions in https://github.com/phetsims/chipper/blob/2e189c04dddd4f8531997d3f68717a6f884be39e/js/grunt/profileFileSize.js#L8-L9 and got a more trustworthy result:
|
This shows that Bottle, Boat, Diamond, etc are ending up in the density build for some reason. Images are the main reason for the large file size. |
DensityBuoyancyScreenView imports Duck, Boat, Bottle. DensityMaterials imports 37 textures. I do not see a trivial way to isolate those modules. Are the mystery textures like DIAMOND used in Buoyancy or Buoyancy Basics? Probably not. Let's discuss how much time and complexity we want to invest in reducing the file sizes. |
We discussed and agreed we would like to prune the sizes where possible. |
We went through this today, and it feels like some image files added a while back were very high-res (i.e. Plastic and some metals). At least 100 times bigger than the other textures. We could down-scale them to improve file size. For now I'm just leaving the comment but will take a look later. |
I confirmed density_en_phet.html is now 4.8MB and buoyancy-basics_en_phet.html is 4.9MB, so this issue seems good to close. Nice work @AgustinVallejo. Closing. |
For the phet brand _en files:
Density is 15.6MB
Buoyancy is 16MB
Buoyancy: Basics is 15.7MB
This is much larger than other recent simulations. For instance, Projectile Data Lab is 3MB.
So we should make sure this is well explained and warranted, or see if it must be pruned. We know this is a large simulation, and it also brings three.js + mobius (rendering) and p2 (physics).
In contrast, the published version of density is 4MB
The text was updated successfully, but these errors were encountered: