Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review of pointer areas #170

Closed
Tracked by #123
samreid opened this issue Jun 5, 2024 · 4 comments
Closed
Tracked by #123

review of pointer areas #170

samreid opened this issue Jun 5, 2024 · 4 comments
Assignees
@AgustinVallejo

Comments

@samreid
Copy link
Member

samreid commented Jun 5, 2024

No description provided.

@samreid samreid mentioned this issue Jun 5, 2024
Closed
84 tasks
@samreid samreid changed the title review of pointer areas, see {{GITHUB_ISSUE_LINK}} review of pointer areas Jun 5, 2024
@samreid
Copy link
Member Author

samreid commented Jun 10, 2024

@AgustinVallejo volunteered to take a look, thanks!

@samreid samreid assigned AgustinVallejo and unassigned samreid Jun 10, 2024
@AgustinVallejo
Copy link
Contributor

Looked through the three sims and didn't notice any overlap. However, should these checkboxes and buttons have a bit of dilation? They seem a bit compact, whereas the rest of the UI does use a bit of spacing for touch area.

image

@samreid
Copy link
Member Author

samreid commented Jun 13, 2024

I recommend to dilate vertically until they are touching, and dilate horizontally to cover the icons on the right (if not too complicated)

AgustinVallejo added a commit that referenced this issue Jun 13, 2024
@AgustinVallejo
Replacing GridBox with a simpler layout to allow for the checkbox poi…
cedb8f2 
…nter area to encompass the icons, see #170
@AgustinVallejo
Copy link
Contributor

This is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AgustinVallejo AgustinVallejo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @AgustinVallejo