Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write model.md #166

Closed
Tracked by #123
samreid opened this issue Jun 5, 2024 · 5 comments
Closed
Tracked by #123

Write model.md #166

samreid opened this issue Jun 5, 2024 · 5 comments

Comments

@samreid
Copy link
Member

samreid commented Jun 5, 2024

No description provided.

@samreid samreid mentioned this issue Jun 5, 2024
84 tasks
@samreid samreid changed the title model.md, see {{GITHUB_ISSUE_LINK}}. Familiarize yourself with the model by reading model.md. Does it adequately Write model.md Jun 5, 2024
@AgustinVallejo AgustinVallejo self-assigned this Jun 10, 2024
AgustinVallejo added a commit to phetsims/buoyancy-basics that referenced this issue Jun 14, 2024
AgustinVallejo added a commit to phetsims/buoyancy that referenced this issue Jun 14, 2024
AgustinVallejo added a commit to phetsims/density that referenced this issue Jun 14, 2024
AgustinVallejo added a commit that referenced this issue Jun 14, 2024
@AgustinVallejo
Copy link
Contributor

Model.md is ready for review, assigning @DianaTavares

@DianaTavares
Copy link

Hi team!

What questions should the model answer?
The document is a description of each screen in each of the 3 sims. This is what I expected to see in a teacher tips document.

I don't have a lot of experience with this. I expected the equations, libraries, limitations, units, etc.

I decide to review other models to compare:

  • Kepler also describes each screen, but also includes, units, trajectories, and other data.

  • CCK-common is also a site, and @zepumph (who created the issue, not sure who wrote the model) describes something different, like the principal variables and data of the sim.

  • While ESP has equations.

Does the model have a checklist of what to include or what questions to answer?

@AgustinVallejo
Copy link
Contributor

AgustinVallejo commented Jun 18, 2024

Discussed today on standup:

@zepumph zepumph removed their assignment Jun 18, 2024
AgustinVallejo added a commit to phetsims/buoyancy-basics that referenced this issue Jun 19, 2024
AgustinVallejo added a commit that referenced this issue Jun 19, 2024
@AgustinVallejo
Copy link
Contributor

Back to youu @DianaTavares, I addressed the discussed items. If you think it's done, feel free to close, or assign back otherwise.

@AgustinVallejo AgustinVallejo removed their assignment Jun 19, 2024
@DianaTavares
Copy link

It is perfect thanks!!

zepumph added a commit to phetsims/buoyancy that referenced this issue Jun 28, 2024
zepumph added a commit to phetsims/density that referenced this issue Jun 28, 2024
zepumph added a commit to phetsims/buoyancy-basics that referenced this issue Jun 28, 2024
zepumph added a commit that referenced this issue Jun 28, 2024
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/perennial that referenced this issue Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants