Skip to content

Commit

Permalink
remove TODO, #163
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Kauzmann <[email protected]>
  • Loading branch information
zepumph committed Jul 23, 2024
1 parent 93051c6 commit e9e113d
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion js/common/model/CompareBlockSetModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,6 @@ export default class CompareBlockSetModel extends BlockSetModel<BlockSet> {

// We must undefer the Cube's materialProperty first, in order for the DynamicProperty in DensityAccordionBox to be correctly unregistered
// We do not know why scheduling a NOTIFY order dependency was not sufficient
// TODO: Does this logic simplify now that Material is mutable? See https://github.com/phetsims/density-buoyancy-common/issues/163 and https://github.com/phetsims/density-buoyancy-common/issues/273 and https://github.com/phetsims/buoyancy/issues/67
propertyStateHandlerSingleton.registerPhetioOrderDependency( cube.materialProperty, PropertyStatePhase.UNDEFER, model.blockSetProperty, PropertyStatePhase.UNDEFER );

return cube;
Expand Down

0 comments on commit e9e113d

Please sign in to comment.