Skip to content

Commit

Permalink
update TODO: #280
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Kauzmann <[email protected]>
  • Loading branch information
zepumph committed Jul 24, 2024
1 parent e39c558 commit ca655a7
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions js/common/model/CompareBlockSetModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export default class CompareBlockSetModel extends BlockSetModel<BlockSet> {

// We must undefer the Cube's materialProperty first, in order for the DynamicProperty in DensityAccordionBox to be correctly unregistered
// We do not know why scheduling a NOTIFY order dependency was not sufficient
// TODO: We may not need these anymore, https://github.com/phetsims/density-buoyancy-common/issues/273
// TODO: We may not need these anymore, https://github.com/phetsims/density-buoyancy-common/issues/280
propertyStateHandlerSingleton.registerPhetioOrderDependency( cube.materialProperty, PropertyStatePhase.UNDEFER, model.blockSetProperty, PropertyStatePhase.UNDEFER );
return cube;
} ) :
Expand Down Expand Up @@ -260,10 +260,13 @@ export default class CompareBlockSetModel extends BlockSetModel<BlockSet> {
const options = combineOptions<StrictCubeOptions>( {
customMaterialOptions: {
density: initialDensity,
densityPropertyOptions: {
phetioReadOnly: true
},
colorProperty: densityAdjustedColorProperty
},
materialPropertyOptions: {
phetioReadOnly: true // TODO: And readonly density!!! https://github.com/phetsims/density-buoyancy-common/issues/273
phetioReadOnly: true
},
availableMassMaterials: [
...initialMaterials,
Expand Down

0 comments on commit ca655a7

Please sign in to comment.