Make abstract constructors protected, see #123

phetsims · May 7, 2024 · bf40a1c · bf40a1c
1 parent 0f2fece
commit bf40a1c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/js/buoyancy/model/ApplicationsMass.ts b/js/buoyancy/model/ApplicationsMass.ts
@@ -3,7 +3,7 @@
 /**
  * A general class for shared functionality between the boat and bottle.
  *
- * @author Agustín Vallejo
+ * @author Agustín Vallejo (PhET Interactive Simulations)
  */
 
 import NumberProperty from '../../../../axon/js/NumberProperty.js';
@@ -27,7 +27,7 @@ export default abstract class ApplicationsMass extends Mass {
 
   public readonly intersectionGroup: THREE.Group;
 
-  public constructor( engine: PhysicsEngine, displacementVolumeProperty: NumberProperty, options: ApplicationsMassOptions ) {
+  protected constructor( engine: PhysicsEngine, displacementVolumeProperty: NumberProperty, options: ApplicationsMassOptions ) {
 
     assert && assert( !options.canRotate );
 

diff --git a/js/buoyancy/view/ReadoutListAccordionBox.ts b/js/buoyancy/view/ReadoutListAccordionBox.ts
@@ -60,7 +60,7 @@ export default abstract class ReadoutListAccordionBox<ReadoutType> extends Accor
   protected readonly readoutBox: VBox;
   protected readonly contentWidthMaxProperty: TReadOnlyProperty<number>;
 
-  public constructor(
+  protected constructor(
     titleStringProperty: TReadOnlyProperty<string>,
     providedOptions?: ReadoutListAccordionBoxOptions<ReadoutType>
   ) {