Skip to content

Commit

Permalink
Renaming DisplayOptionsNode -> BuoyancyDisplayOptionsNode see phetsim…
Browse files Browse the repository at this point in the history
  • Loading branch information
AgustinVallejo committed Mar 18, 2024
1 parent ff2dafc commit b841412
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 16 deletions.
4 changes: 2 additions & 2 deletions js/buoyancy/view/BuoyancyApplicationsScreenView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import Material from '../../common/model/Material.js';
import DensityBuoyancyCommonColors from '../../common/view/DensityBuoyancyCommonColors.js';
import DensityBuoyancyScreenView, { DensityBuoyancyScreenViewOptions } from '../../common/view/DensityBuoyancyScreenView.js';
import LiquidDensityControlNode from '../../common/view/LiquidDensityControlNode.js';
import DisplayOptionsNode from '../../common/view/DisplayOptionsNode.js';
import BuoyancyDisplayOptionsNode from '../../common/view/BuoyancyDisplayOptionsNode.js';
import MaterialMassVolumeControlNode from '../../common/view/MaterialMassVolumeControlNode.js';
import densityBuoyancyCommon from '../../densityBuoyancyCommon.js';
import DensityBuoyancyCommonStrings from '../../DensityBuoyancyCommonStrings.js';
Expand Down Expand Up @@ -249,7 +249,7 @@ export default class BuoyancyApplicationsScreenView extends DensityBuoyancyScree
margin: MARGIN
} ) );

const displayOptionsNode = new DisplayOptionsNode( model );
const displayOptionsNode = new BuoyancyDisplayOptionsNode( model );

const densityBox = new DensityAccordionBox( {
expandedProperty: model.densityExpandedProperty,
Expand Down
6 changes: 3 additions & 3 deletions js/buoyancy/view/BuoyancyExploreScreenView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import DensityBuoyancyCommonStrings from '../../DensityBuoyancyCommonStrings.js'
import BuoyancyExploreModel from '../model/BuoyancyExploreModel.js';
import arrayRemove from '../../../../phet-core/js/arrayRemove.js';
import DensityAccordionBox from './DensityAccordionBox.js';
import DisplayOptionsNode from '../../common/view/DisplayOptionsNode.js';
import BuoyancyDisplayOptionsNode from '../../common/view/BuoyancyDisplayOptionsNode.js';
import SubmergedAccordionBox from './SubmergedAccordionBox.js';
import PatternStringProperty from '../../../../axon/js/PatternStringProperty.js';
import BlocksRadioButtonGroup from '../../common/view/BlocksRadioButtonGroup.js';
Expand All @@ -43,9 +43,9 @@ export default class BuoyancyExploreScreenView extends DensityBuoyancyScreenView
cameraLookAt: DensityBuoyancyCommonConstants.BUOYANCY_CAMERA_LOOK_AT
}, options ) );

const displayOptionsNode = new DisplayOptionsNode( model );
const buoyancyDisplayOptionsNode = new BuoyancyDisplayOptionsNode( model );

this.addChild( new AlignBox( new Panel( displayOptionsNode, DensityBuoyancyCommonConstants.PANEL_OPTIONS ), {
this.addChild( new AlignBox( new Panel( buoyancyDisplayOptionsNode, DensityBuoyancyCommonConstants.PANEL_OPTIONS ), {
alignBoundsProperty: this.visibleBoundsProperty,
xAlign: 'left',
yAlign: 'bottom',
Expand Down
4 changes: 2 additions & 2 deletions js/buoyancy/view/BuoyancyIntroScreenView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import VerticalAquaRadioButtonGroup from '../../../../sun/js/VerticalAquaRadioBu
import DensityBuoyancyCommonConstants from '../../common/DensityBuoyancyCommonConstants.js';
import Material from '../../common/model/Material.js';
import DensityBuoyancyScreenView, { DensityBuoyancyScreenViewOptions } from '../../common/view/DensityBuoyancyScreenView.js';
import DisplayOptionsNode from '../../common/view/DisplayOptionsNode.js';
import BuoyancyDisplayOptionsNode from '../../common/view/BuoyancyDisplayOptionsNode.js';
import densityBuoyancyCommon from '../../densityBuoyancyCommon.js';
import DensityBuoyancyCommonStrings from '../../DensityBuoyancyCommonStrings.js';
import BuoyancyIntroModel, { BlockSet } from '../model/BuoyancyIntroModel.js';
Expand Down Expand Up @@ -82,7 +82,7 @@ export default class BuoyancyIntroScreenView extends DensityBuoyancyScreenView<B
margin: MARGIN
} ) );

const displayOptionsPanel = new Panel( new DisplayOptionsNode( model, { includeVectorScaleControl: false } ),
const displayOptionsPanel = new Panel( new BuoyancyDisplayOptionsNode( model, { includeVectorScaleControl: false } ),
DensityBuoyancyCommonConstants.PANEL_OPTIONS );
this.addChild( new AlignBox( displayOptionsPanel, {
alignBoundsProperty: this.visibleBoundsProperty,
Expand Down
4 changes: 2 additions & 2 deletions js/buoyancy/view/BuoyancyLabScreenView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import densityBuoyancyCommon from '../../densityBuoyancyCommon.js';
import BuoyancyLabModel from '../model/BuoyancyLabModel.js';
import arrayRemove from '../../../../phet-core/js/arrayRemove.js';
import DensityAccordionBox from './DensityAccordionBox.js';
import DisplayOptionsNode from '../../common/view/DisplayOptionsNode.js';
import BuoyancyDisplayOptionsNode from '../../common/view/BuoyancyDisplayOptionsNode.js';
import BlockControlNode from '../../common/view/BlockControlNode.js';
import MultiSectionPanelsNode from '../../common/view/MultiSectionPanelsNode.js';
import FluidDisplacedPanel from './FluidDisplacedPanel.js';
Expand Down Expand Up @@ -54,7 +54,7 @@ export default class BuoyancyLabScreenView extends DensityBuoyancyScreenView<Buo
new FluidDisplacedPanel( this.waterLevelVolumeProperty, maxBlockVolume, {
visibleProperty: model.showDisplacedFluidProperty
} ),
new MultiSectionPanelsNode( [ new DisplayOptionsNode( model, {
new MultiSectionPanelsNode( [ new BuoyancyDisplayOptionsNode( model, {
showFluidDisplacedProperty: model.showDisplacedFluidProperty
} ) ] )
]
Expand Down
4 changes: 2 additions & 2 deletions js/buoyancy/view/BuoyancyShapesScreenView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import Panel from '../../../../sun/js/Panel.js';
import DensityBuoyancyCommonConstants from '../../common/DensityBuoyancyCommonConstants.js';
import Material from '../../common/model/Material.js';
import LiquidDensityControlNode from '../../common/view/LiquidDensityControlNode.js';
import DisplayOptionsNode from '../../common/view/DisplayOptionsNode.js';
import BuoyancyDisplayOptionsNode from '../../common/view/BuoyancyDisplayOptionsNode.js';
import PrimarySecondaryPanelsNode from '../../common/view/PrimarySecondaryPanelsNode.js';
import densityBuoyancyCommon from '../../densityBuoyancyCommon.js';
import DensityAccordionBox from './DensityAccordionBox.js';
Expand Down Expand Up @@ -80,7 +80,7 @@ export default class BuoyancyShapesScreenView extends DensityBuoyancyScreenView<
margin: MARGIN
} ) );

const displayOptionsNode = new DisplayOptionsNode( model );
const displayOptionsNode = new BuoyancyDisplayOptionsNode( model );

this.addChild( new AlignBox( new Panel( displayOptionsNode, DensityBuoyancyCommonConstants.PANEL_OPTIONS ), {
alignBoundsProperty: this.visibleBoundsProperty,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ type SelfOptions = {
showFluidDisplacedProperty?: Property<boolean> | null;
};

type DisplayOptionsNodeOptions = SelfOptions & VBoxOptions;
type BuoyancyDisplayOptionsNodeOptions = SelfOptions & VBoxOptions;

export default class DisplayOptionsNode extends VBox {
public constructor( model: DensityBuoyancyModel, providedOptions?: DisplayOptionsNodeOptions ) {
export default class BuoyancyDisplayOptionsNode extends VBox {
public constructor( model: DensityBuoyancyModel, providedOptions?: BuoyancyDisplayOptionsNodeOptions ) {

const options = optionize<DisplayOptionsNodeOptions, SelfOptions, VBoxOptions>()( {
const options = optionize<BuoyancyDisplayOptionsNodeOptions, SelfOptions, VBoxOptions>()( {
includeVectorScaleControl: true,
showFluidDisplacedProperty: null,
spacing: DensityBuoyancyCommonConstants.MARGIN,
Expand Down Expand Up @@ -134,4 +134,4 @@ export default class DisplayOptionsNode extends VBox {
}
}

densityBuoyancyCommon.register( 'DisplayOptionsNode', DisplayOptionsNode );
densityBuoyancyCommon.register( 'BuoyancyDisplayOptionsNode', BuoyancyDisplayOptionsNode );

1 comment on commit b841412

@AgustinVallejo
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.