Skip to content

Commit

Permalink
Remove unused IO Type, minor adjustments, see #123
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed May 8, 2024
1 parent eb714cb commit 8548584
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 11 deletions.
7 changes: 0 additions & 7 deletions js/buoyancy/model/Boat.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import TProperty from '../../../../axon/js/TProperty.js';
import Ray3 from '../../../../dot/js/Ray3.js';
import Multilink from '../../../../axon/js/Multilink.js';
import TReadOnlyProperty from '../../../../axon/js/TReadOnlyProperty.js';
import IOType from '../../../../tandem/js/types/IOType.js';
import { MassShape } from '../../common/model/MassShape.js';
import optionize, { EmptySelfOptions } from '../../../../phet-core/js/optionize.js';
import ApplicationsMass, { ApplicationsMassOptions } from './ApplicationsMass.js';
Expand Down Expand Up @@ -240,12 +239,6 @@ export default class Boat extends ApplicationsMass {

super.reset();
}

public static readonly BoatIO = new IOType( 'BoatIO', {
valueType: Boat,
supertype: Mass.MassIO,
documentation: 'Represents a boat'
} );
}

densityBuoyancyCommon.register( 'Boat', Boat );
12 changes: 8 additions & 4 deletions js/buoyancy/view/BottleView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ type BottleDrawingData = {
frontBottomMaterial: THREE.MeshBasicMaterial;
};


export default class BottleView extends MeasurableMassView {

public readonly bottle: Bottle;

public constructor( bottle: Bottle, modelViewTransform: THREEModelViewTransform,
public constructor( bottle: Bottle,
modelViewTransform: THREEModelViewTransform,
dragBoundsProperty: TReadOnlyProperty<Bounds3>,
showGravityForceProperty: TReadOnlyProperty<boolean>,
showBuoyancyForceProperty: TReadOnlyProperty<boolean>,
Expand All @@ -34,8 +34,12 @@ export default class BottleView extends MeasurableMassView {
forceScaleProperty: TReadOnlyProperty<number>,
showMassesProperty: TReadOnlyProperty<boolean> ) {

// @ts-expect-error
super( bottle, new THREE.Geometry(), modelViewTransform, dragBoundsProperty,
super( bottle,

// @ts-expect-error
new THREE.Geometry(),
modelViewTransform,
dragBoundsProperty,
showGravityForceProperty,
showBuoyancyForceProperty,
showContactForceProperty,
Expand Down

0 comments on commit 8548584

Please sign in to comment.