Skip to content

Commit

Permalink
remove TODOs, #268
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Kauzmann <[email protected]>
  • Loading branch information
zepumph committed Jul 25, 2024
1 parent 494e1e5 commit 2e106bb
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion js/common/model/Material.ts
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,6 @@ export class CustomLiquidMaterial extends Material {
}, providedOptions );

super( tandem, options );
// TODO: This could be custom color given a "liquid" flag/subtype, https://github.com/phetsims/density-buoyancy-common/issues/268
if ( !this.colorProperty && this.custom ) {
// TODO: can we make this field readonly again? https://github.com/phetsims/density-buoyancy-common/issues/268
this.colorProperty = new DerivedProperty( [ this.densityProperty, this.densityProperty.rangeProperty ], ( density, densityRange ) => {
Expand Down
1 change: 0 additions & 1 deletion js/density/model/DensityMysteryModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,6 @@ export default class DensityMysteryModel extends BlockSetModel<MysteryBlockSet>
const cubeTandem = randomTandem.createTandem( `block${tags[ i ].tandemName}` );

const colorProperty = new ColorProperty( colors[ i ].value, {
// TODO: Is this where we want things? https://github.com/phetsims/density-buoyancy-common/issues/268
tandem: cubeTandem.createTandem( 'materialProperty' ).createTandem( 'customMaterial' ).createTandem( 'colorProperty' )
} );

Expand Down

0 comments on commit 2e106bb

Please sign in to comment.