Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BucketNode #64

Closed
jonathanolson opened this issue Aug 13, 2015 · 4 comments
Closed

BucketNode #64

jonathanolson opened this issue Aug 13, 2015 · 4 comments
Assignees
@jonathanolson
Labels
dev:code-review

Comments

@jonathanolson
Copy link
Contributor

We have standard code for displaying buckets in scenery-phet, so that sims are consistent. Is there any reason this code for displaying the bucket shouldn't be used? (Just the bucket, not what is in it).

Review: #31
andrey-zelenkov added a commit that referenced this issue Sep 14, 2015
@andrey-zelenkov
#64 replaced painting bucket node by standard scenery-phew component
4349238
@andrey-zelenkov
Copy link
Contributor

Replaced painting bucket node by standard scenery-phet component. Reassign to @jonathanolson for verification.

@jonathanolson
Copy link
Contributor Author

Bucket use looks good, but isn't the clipping not needed? It should be possible to put the pointsNode under the BucketFront, and in front of the BucketHole, so that it's not needed.

andrey-zelenkov added a commit that referenced this issue Sep 15, 2015
@andrey-zelenkov
#64 removed clip shape for points
69c5a72
@andrey-zelenkov
Copy link
Contributor

Good point, thank you! Removed clip shape for points. Reassign to @jonathanolson for verifcation.

@jonathanolson
Copy link
Contributor Author

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @andrey-zelenkov