Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curve fit listeners #60

Closed
jonathanolson opened this issue Aug 13, 2015 · 3 comments
Closed

Curve fit listeners #60

jonathanolson opened this issue Aug 13, 2015 · 3 comments

Comments

@jonathanolson
Copy link
Contributor

There is a lot of code dedicated to adding/removing updateFitBinded based on whether the curve is best/adjustable.

It seems simpler to always have a listener attached, where the listener checks the fitType (and only runs things if it is adjustable). Thoughts?

Review: #31

@andrey-zelenkov
Copy link
Contributor

No, it was made for optimization (to prevent extra updateFit calls when fit type is adjustable). There are necessary "if" condition is already present in updateFit function. Removed linking/unlinking of curve parameters while mode switching. Reassign to @jonathanolson for verification.

@jonathanolson
Copy link
Contributor Author

Removing review tag, will look into it.

@veillette
Copy link
Contributor

This issue is irrelevant since the simulation does no longer make use of properties to keep track of the parameter a, b, c ,d.
All the code regarding saving, deleting and stashing status of properties has bee removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants