Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

barometers shift position #105

Closed
veillette opened this issue Mar 18, 2017 · 3 comments
Closed

barometers shift position #105

veillette opened this issue Mar 18, 2017 · 3 comments
Assignees
@veillette

Comments

@veillette
Copy link
Contributor

image

Procedure to repeat:
Click on curve
Set two points at the same position (must be exactly at the same position)
This was referenced Mar 18, 2017
Closed
Closed
@phet-steele
Copy link
Contributor

@veillette assuming you don't hit this assertion while following your steps, you can then try to adjust the error bars:

Error: Assertion failed: rectHeight should be a finite number
    at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/snapshot-1492521779193/assert/js/assert.js:21:13)
    at Rectangle.setRectHeight (https://bayes.colorado.edu/continuous-testing/snapshot-1492521779193/scenery/js/nodes/Rectangle.js?bust=1492525997799:415:17)
    at Array.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1492521779193/curve-fitting/js/curve-fitting/view/BarometerR2Node.js?bust=1492525997799:56:21)
    at Emitter.emit2 (https://bayes.colorado.edu/continuous-testing/snapshot-1492521779193/axon/js/Emitter.js?bust=1492525997799:147:49)
    at NumberProperty._notifyObservers (https://bayes.colorado.edu/continuous-testing/snapshot-1492521779193/axon/js/Property.js?bust=1492525997799:208:29)
    at NumberProperty._setAndNotifyObservers (https://bayes.colorado.edu/continuous-testing/snapshot-1492521779193/axon/js/Property.js?bust=1492525997799:197:14)
    at NumberProperty.set (https://bayes.colorado.edu/continuous-testing/snapshot-1492521779193/axon/js/Property.js?bust=1492525997799:141:16)
    at Curve.updateRAndChiSquared (https://bayes.colorado.edu/continuous-testing/snapshot-1492521779193/curve-fitting/js/curve-fitting/model/Curve.js?bust=1492525997799:226:31)
    at Curve.updateFit (https://bayes.colorado.edu/continuous-testing/snapshot-1492521779193/curve-fitting/js/curve-fitting/model/Curve.js?bust=1492525997799:137:12)
    at Array.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1492521779193/curve-fitting/js/curve-fitting/model/CurveFittingModel.js?bust=1492525997799:98:64)
Approximately 4/18/2017, 7:22:59 AM

@veillette
Copy link
Contributor Author

The calculation of r Squared value is inappropriate when we encounter a 0/0 division. We need to check that the numerator is zero.

@veillette veillette self-assigned this Apr 21, 2017
veillette added a commit that referenced this issue Apr 21, 2017
@veillette
more robust calculation of rSquared (see #105). Adding back assertion…
c33fc91 
…s for rSquared
@veillette
Copy link
Contributor Author

the previous commit addresses this issue. After running FuzzMouse for ten minutes no assertions were hit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veillette veillette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phet-steele @veillette