-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update color of dashed lines #87
Comments
@arouinfar I was able to have the color update along with the charge value. The colors themselves are a little muted compared to the slider thumb, but that can easily be changed if desired. |
That's great @mbarlow12. I pulled all, but I'm not seeing any color changes. Did you commit the changes to master? |
No I didn't. They're made in 1.0 branch currently. I'll be sure to pull them ASAP. |
@arouinfar I just merged the branches into master. |
Looks awesome @mbarlow12! Thanks. |
1.0.0-rc.6 this looks good. |
For phetsims/qa#221
In GFL(B), the color of the dashed lines was meant to match up with the masses. In CL, charges can be red or blue, which can lead to this somewhat odd-looking situation.
We could either
rgb(180, 180, 180)
would work nicely.Option (2) would look a bit nicer, but option (1) seems quicker/easier. If option (2) is a quick(ish) and non-invasive change (the next rc could still be a spot check), then I'd like to pursue it @mbarlow12. Otherwise, let's go with option (1).
The text was updated successfully, but these errors were encountered: