Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color of dashed lines #87

Closed
arouinfar opened this issue Nov 28, 2018 · 6 comments
Closed

Update color of dashed lines #87

arouinfar opened this issue Nov 28, 2018 · 6 comments
Assignees

Comments

@arouinfar
Copy link
Contributor

For phetsims/qa#221

In GFL(B), the color of the dashed lines was meant to match up with the masses. In CL, charges can be red or blue, which can lead to this somewhat odd-looking situation.
image

We could either

  1. Make both lines gray. rgb(180, 180, 180) would work nicely.

  1. Make the line color adaptive like the Charge slider thumbs: blue when negative, red when positive, gray when zero.

Option (2) would look a bit nicer, but option (1) seems quicker/easier. If option (2) is a quick(ish) and non-invasive change (the next rc could still be a spot check), then I'd like to pursue it @mbarlow12. Otherwise, let's go with option (1).

mbarlow12 added a commit to phetsims/inverse-square-law-common that referenced this issue Nov 29, 2018
mbarlow12 added a commit to phetsims/inverse-square-law-common that referenced this issue Nov 29, 2018
@mbarlow12
Copy link
Contributor

@arouinfar I was able to have the color update along with the charge value. The colors themselves are a little muted compared to the slider thumb, but that can easily be changed if desired.

@arouinfar
Copy link
Contributor Author

That's great @mbarlow12. I pulled all, but I'm not seeing any color changes. Did you commit the changes to master?

@mbarlow12
Copy link
Contributor

No I didn't. They're made in 1.0 branch currently. I'll be sure to pull them ASAP.

@mbarlow12
Copy link
Contributor

@arouinfar I just merged the branches into master.

@arouinfar
Copy link
Contributor Author

Looks awesome @mbarlow12! Thanks.

@KatieWoe
Copy link
Contributor

KatieWoe commented Dec 7, 2018

1.0.0-rc.6 this looks good.

@KatieWoe KatieWoe closed this as completed Dec 7, 2018
This was referenced Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants