Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxes overlap #83

Closed
KatieWoe opened this issue Nov 27, 2018 · 2 comments
Closed

Boxes overlap #83

KatieWoe opened this issue Nov 27, 2018 · 2 comments
Assignees

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#221. Likely connected to #81. When stringTest=double but not long the Charge 2 box and the Force values box overlap. Discovered on an iPad, but occurs elsewhere. See image bellow.
img_1340

@arouinfar
Copy link
Contributor

Good catch @KatieWoe!

Comparing Macro Scale to Atomic Scale, it seems that the problem is that the Charge panels haven't been given a maxWidth. Macro scale has longer units (μC) compared to Atomic Scale (e), which leads to a wider panel.
image
image

However, I'm not so sure the Charge panels need to expand at all, since there's quite a bit of white space around "Charge".
image

@arouinfar arouinfar removed their assignment Nov 27, 2018
mbarlow12 added a commit to phetsims/inverse-square-law-common that referenced this issue Nov 29, 2018
@KatieWoe
Copy link
Contributor Author

KatieWoe commented Dec 7, 2018

1.0.0-rc.6 looks good.

@KatieWoe KatieWoe closed this as completed Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants