Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots #82

Closed
arouinfar opened this issue Nov 16, 2018 · 5 comments
Closed

Screenshots #82

arouinfar opened this issue Nov 16, 2018 · 5 comments
Assignees

Comments

@arouinfar
Copy link
Contributor

For phetsims/qa#221

Just realized we don't have any screenshots for this sim! Self-assigning to create some screenshots.

Looks like this slipped through the cracks during code review, but this sim doesn't have an assets directory. @mbarlow12 can you create the assets directory?

@arouinfar
Copy link
Contributor Author

@KatieWoe let's go with these screenshots. The assets directory is currently missing, so once @mbarlow12 adds it, you can commit the screenshots.

Main:
image

Alternates:
image
image

@arouinfar arouinfar assigned KatieWoe and unassigned arouinfar Nov 16, 2018
@KatieWoe
Copy link
Contributor

Here are the screenshots. Will put in github when assets is made. Do they need to go in anything besides the main branch?
coulombs-law-screenshot
coulombs-law-screenshot-alt1
coulombs-law-screenshot-alt2

@arouinfar
Copy link
Contributor Author

Thanks @KatieWoe! I would put them in master and 1.0 once the assets directory has been created.

KatieWoe added a commit that referenced this issue Nov 20, 2018
KatieWoe added a commit that referenced this issue Nov 20, 2018
@KatieWoe KatieWoe removed their assignment Nov 20, 2018
@KatieWoe
Copy link
Contributor

Above commits should do it. Please review and close if acceptable.

@arouinfar
Copy link
Contributor Author

Looks good @KatieWoe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants