Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust min/max threshold for figures #39

Closed
arouinfar opened this issue Jan 18, 2018 · 4 comments
Closed

Adjust min/max threshold for figures #39

arouinfar opened this issue Jan 18, 2018 · 4 comments
Assignees

Comments

@arouinfar
Copy link
Contributor

When reviewing #27, I noticed that the figures could be a bit more responsive at the extremes.

At the default values, the figure appears to be figure_pull_1/ figure_pull_atomic_1, so decreasing the force does not show any apparent change in the figure's stance.

On Atomic Scale, there is a slightly larger range of forces that can go off-screen, as compared to Macro. (Partly due to the user's ability to get the charges closer to one another.) At the minimum distance, the figure takes the deepest stance for any charge combination greater than 1/2 e.

I think it would be a helpful visual cue if there was a bit more resolution at the lower and upper ends of the force range. The threshold for figure_1 could be a bit lower (on both screens) and the threshold for figure_31 could be a bit higher (on Atomic Scale). That way, students may still see the figure's stance move a bit, even when the vectors themselves are too extreme for a change in their magnitude to be noticeable.

I realize there will always be some degree of saturation where the force increases/decreases but the figure doesn't appear to change, but I would like to reduce the range where saturation occurs.

@mbarlow12
Copy link
Contributor

@arouinfar I'm not sure I fully understand what you're looking for here. Could we take a few minutes today or tomorrow to discuss?

@arouinfar
Copy link
Contributor Author

After speaking with @mbarlow12, I've learned that the mapping between the force and the figure is a bit complicated, particularly because the force can be positive or negative.

We spent some time adjusting PULL_RANGE_MULTIPLIER, and it looks like that may give me the results I'm looking for. I will experiment a bit with my local copy, and recommend a value to @mbarlow12.

@arouinfar
Copy link
Contributor Author

@mbarlow12 let's go with PULL_RANGE_MULTIPLIER = 1/50.

@mbarlow12
Copy link
Contributor

Thanks! Fixed in above commit. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants