Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard nav issue when starting after charge slider #100

Closed
KatieWoe opened this issue Dec 20, 2018 · 4 comments
Closed

Keyboard nav issue when starting after charge slider #100

KatieWoe opened this issue Dec 20, 2018 · 4 comments
Assignees
Labels

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#243
Keyboard nav seems to behave a bit oddly if you start in after manipulating one of the charge sliders. I'm in firefox, but chrome was being a bit odd too. I don't think its broken, but you might want to take a look for yourself. It takes two key presses to start in firefox, and it starts in an unexpected location.
But it doesn't do this if you were manipulating anything but those sliders. Chrome does something similar, but it starts at the beginning after manipulating the sliders. Same with edge.

@mbarlow12
Copy link
Contributor

@KatieWoe I've confirmed the same behavior in Rutherford Scattering as well, so this is an issue for scenery-phet for the NumberControl. Making an issue and linking.

@jessegreenberg
Copy link
Contributor

@mbarlow12 I verified that this issue is fixed from the phetsims/scenery-phet#452.

@jessegreenberg
Copy link
Contributor

Removing my assignment, I think this is fixed-pending-testing.

@arouinfar
Copy link
Contributor

Since @jessegreenberg verified this issue in phetsims/scenery-phet#452 (comment) and @lmulhall-phet checked this off in rc.9, I will go ahead and close. I am also unable to reproduce in rc.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants