use isDisposable: false instead of overridden dispose methods, phet…

…sims/axon#436
phetsims · Jul 10, 2023 · dea3b04 · dea3b04
1 parent 56be7ed
commit dea3b04
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 20 deletions.
diff --git a/js/common/view/ElapsedTimeNumberDisplay.js b/js/common/view/ElapsedTimeNumberDisplay.js
@@ -53,20 +53,12 @@ class ElapsedTimeNumberDisplay extends NumberDisplay {
           size: CollisionLabConstants.DISPLAY_FONT.size
         } )
       },
-      decimalPlaces: CollisionLabConstants.DISPLAY_DECIMAL_PLACES
-
+      decimalPlaces: CollisionLabConstants.DISPLAY_DECIMAL_PLACES,
+      isDisposable: false
     }, options );
 
     super( elapsedTimeProperty, options.displayRange, options );
   }
-
-  /**
-   * @public
-   * @override
-   */
-  dispose() {
-    assert && assert( false, 'ElapsedTimeNumberDisplay is not intended to be disposed' );
-  }
 }
 
 collisionLab.register( 'ElapsedTimeNumberDisplay', ElapsedTimeNumberDisplay );

diff --git a/js/common/view/KineticEnergyNumberDisplay.js b/js/common/view/KineticEnergyNumberDisplay.js
@@ -38,20 +38,12 @@ class KineticEnergyNumberDisplay extends PlayAreaNumberDisplay {
       textOptions: {
         font: CollisionLabConstants.DISPLAY_FONT
       },
-      maxWidth: 300 // constrain width for i18n, determined empirically.
-
+      maxWidth: 300, // constrain width for i18n, determined empirically.
+      isDisposable: false
     }, options );
 
     super( totalKineticEnergyProperty, options );
   }
-
-  /**
-   * @public
-   * @override
-   */
-  dispose() {
-    assert && assert( false, 'KineticEnergyNumberDisplay is not intended to be disposed' );
-  }
 }
 
 collisionLab.register( 'KineticEnergyNumberDisplay', KineticEnergyNumberDisplay );