Skip to content

Commit

Permalink
Handling a minor REVIEW comment
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathanolson committed Sep 29, 2020
1 parent 4cd8b42 commit b8728db
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions js/common/model/CollisionLabModel.js
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,9 @@ class CollisionLabModel {
assert && assert( typeof dt === 'number' && dt !== 0, `invalid dt: ${dt}` );

// Step the Physics Engine and update the elapsedTimeProperty value.
//REVIEW: Should we store the old "elapsed time" and pass it through to the collisionEngine step? Or are we
//REVIEW: supporting the elapsedTimeProperty being changed on modifications?
const previousElapsedTime = this.elapsedTimeProperty.value;
this.elapsedTimeProperty.value += dt;
this.collisionEngine.step( dt, this.elapsedTimeProperty.value - dt );
this.collisionEngine.step( dt, previousElapsedTime );
}

/**
Expand Down

0 comments on commit b8728db

Please sign in to comment.