Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some images have shifted #150

Closed
phet-steele opened this issue Sep 8, 2017 · 3 comments
Closed

Some images have shifted #150

phet-steele opened this issue Sep 8, 2017 · 3 comments
Assignees
Labels

Comments

@phet-steele
Copy link
Contributor

Did they get shifted on purpose? The first version where these are moved is dev.158. I only see this on the hand and dog.

1.0.0-dev.160:
screen shot 2017-09-08 at 11 31 27 am

1.0.0-dev.157 (presumably correct):
screen shot 2017-09-08 at 11 34 26 am

1.0.0-dev.160:
screen shot 2017-09-08 at 11 37 48 am

1.0.0-dev.157 (presumably correct):
screen shot 2017-09-08 at 11 37 53 am

Seen on macOs 10.12.6 Chrome. For phetsims/qa/issues/48.

URL: http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-dc/1.0.0-dev.160/circuit-construction-kit-dc_en.html
Version: 1.0.0-dev.160 2017-09-07 18:03:16 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36
Language: en-US
Window: 1920x1014
Pixel Ratio: 2/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 32 uniform: 1024
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 80)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {"assert":{"sha":"928741cf","branch":"master"},"axon":{"sha":"7083c475","branch":"master"},"babel":{"sha":"5b127384","branch":"master"},"brand":{"sha":"cfca902d","branch":"master"},"chipper":{"sha":"66110366","branch":"master"},"circuit-construction-kit-common":{"sha":"a165d9ef","branch":"master"},"circuit-construction-kit-dc":{"sha":"2722c8da","branch":"master"},"dot":{"sha":"630fb098","branch":"master"},"joist":{"sha":"f51d5ab4","branch":"master"},"kite":{"sha":"dc5c4382","branch":"master"},"phet-core":{"sha":"30da7870","branch":"master"},"phetcommon":{"sha":"1a5ceb11","branch":"master"},"query-string-machine":{"sha":"c74e454e","branch":"master"},"scenery":{"sha":"fc2d1cf1","branch":"master"},"scenery-phet":{"sha":"55f204d3","branch":"master"},"sherpa":{"sha":"e29820c9","branch":"master"},"sun":{"sha":"1ed8afa5","branch":"master"},"tandem":{"sha":"37243b99","branch":"master"},"twixt":{"sha":"6f27c1ff","branch":"master"}}

@samreid
Copy link
Member

samreid commented Sep 8, 2017

Thanks @phet-steele, dev.157 is correct, I'll see what's happened here.

samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Sep 8, 2017
@samreid
Copy link
Member

samreid commented Sep 8, 2017

Fixed in preceding commit, @phet-steele would you like a new version?

@samreid samreid removed their assignment Sep 8, 2017
samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Sep 8, 2017
@phet-steele
Copy link
Contributor Author

@phet-steele would you like a new version?

Nope!

Fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants