Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Tap circuit element to edit' is initially missing in launched sim #973

Closed
Nancy-Salpepi opened this issue Feb 20, 2023 · 5 comments
Closed

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip and iPad

Operating System
13.1 and iOS 16.3

Browser
Safari

Problem description
For phetsims/qa#900, in Studio, if I add objects to the play area and then launch the sim, the 'Tap circuit element to edit' message isn't there. It appears after selecting an object or adding another object to the play area.

Steps to reproduce

  1. In Studio, add object to play area --Tap message is on the bottom of the screen
  2. Press Test button --Tap message isn't there

Visuals

taptoedit.mp4
@Nancy-Salpepi
Copy link
Author

I am also seeing odd things in the State Wrapper with this. For example:

  1. Set State Rate = 0
  2. Add a couple of elements to the upstream sim and press Set State Now--the 'Tap circuit' message doesn't appear in the downstream sim
  3. Hit Set State Now again --the message appears in the downstream sim
  4. Press Reset All in the upstream sim and then press Set State Now -- the elements disappear in the downstream sim, but the the 'Tap circuit' message is still there.
tap.message.mp4

@matthew-blackman
Copy link

@arouinfar agrees that this is important to fix for the PhET-iO release milestone. @samreid @zepumph and I will work on this.

@samreid
Copy link
Member

samreid commented Feb 21, 2023

Fixed, @Nancy-Salpepi can you please verify?

@Nancy-Salpepi
Copy link
Author

This is working nicely in both Studio and State wrappers now in master 🙂.

@samreid
Copy link
Member

samreid commented Feb 21, 2023

Thanks, closing.

@samreid samreid closed this as completed Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants