Control panels do not horizontally align correctly when sensor tool icons removed from sensor toolbox

[matthew-blackman]

When the voltmeter or ammeter icons are removed from the sensor toolbox via studio, the control panels do not align correctly. See screenshot below:

Investigating with the scenery inspector, it looks like the 'advanced' options panel is aligning left within a layout component that is larger than the panel itself. See screenshot below:

[AgustinVallejo]

Will look into!

[matthew-blackman]

@AgustinVallejo @samreid and I made some progress on this. We found that if titleAlignX is set to 'center' in AdvancedAccordionBox, the panel alignment works but the title text is no longer left aligned. See below:

This is not an ideal fix but it is getting us closer to the heart of the issue. Additionally, I found that there is an issue with the panel group width if the titleText string is long. See below:

[jonathanolson]

This looks like something I could help with, might be related to the layout engine?

[jonathanolson]

Should be fixed with the above commits. It seems like code was added that changed the collapsedBox's bounds AFTER we used those bounds for the workaroundBox.

I also patched a case where the rectBounds of the workaroundBox would not have been getting properly updated.

[samreid]

Excellent, thanks @jonathanolson!

[matthew-blackman]

Things are looking great @jonathanolson thanks for looking into this!

One remaining issue is the width of the advanced accordion box when the title text is long. This is likely a CCK issue that I can look into. See below:

[samreid]

Perhaps try to find a way to reduce the maxWidth of that accordion box title/label?

[marlitas]

phetsims/sun#803 may be related to this issue.

[samreid]

I believe the best long-term solution for this issue may involve a resizable accordion box, as described in phetsims/sun#803. For this release, it seems a very minor aesthetic issue in a corner case, and perhaps we should consider that, like related issue #939 (comment), this should not be a necessary feature for publishing this release.

@arouinfar OK to remove this issue from the milestone?

[arouinfar]

it seems a very minor aesthetic issue in a corner case

I agree. The behavior has improved since originally reported, and the remaining issue really seems more like an edge case tom.

OK to remove this issue from the milestone?

Yes, untagging it now.

[samreid]

In today's meeting, @arouinfar @matthew-blackman and I agreed that this issue can be closed, because it is a minor cosmetic issue for this sim, and cannot be implemented until the accordion box is resizable in phetsims/sun#803. We suspect another sim will bump the priority of that issue, then we can re-evaluate in other sims as necessary.