-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DC-specific circuit elements and features should not appear in the AC studio tree #900
Comments
@samreid and I agree that the way we are guarding against creating circuit nodes for non-existent circuit element groups in CircuitNode.ts is not as robust as it could be. We recommend doing all of the guarding for non-existent component groups in Circuit.ts, and null-checking for those groups in CircuitNode.ts and CircuitElementToolFactory.ts. This will only apply to groups of screen-specific components. |
Great, nice work! I just factored out one variable. I regenerated the API files in https://github.com/phetsims/phet-io-sim-specific/commit/a3554143882d156300f6f3fa5c09c69e85e6b836. Everything else seems good. Closing. |
We should not add DC-only features (high-voltage and high-resistance components) to AC because they have not been tested in an AC environment and go beyond the scope of the learning goals.
The text was updated successfully, but these errors were encountered: