Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DC-specific circuit elements and features should not appear in the AC studio tree #900

Closed
matthew-blackman opened this issue Nov 28, 2022 · 2 comments

Comments

@matthew-blackman
Copy link

We should not add DC-only features (high-voltage and high-resistance components) to AC because they have not been tested in an AC environment and go beyond the scope of the learning goals.

@matthew-blackman
Copy link
Author

@samreid and I agree that the way we are guarding against creating circuit nodes for non-existent circuit element groups in CircuitNode.ts is not as robust as it could be. We recommend doing all of the guarding for non-existent component groups in Circuit.ts, and null-checking for those groups in CircuitNode.ts and CircuitElementToolFactory.ts. This will only apply to groups of screen-specific components.

@samreid
Copy link
Member

samreid commented Feb 18, 2023

Great, nice work! I just factored out one variable. I regenerated the API files in https://github.com/phetsims/phet-io-sim-specific/commit/a3554143882d156300f6f3fa5c09c69e85e6b836. Everything else seems good. Closing.

@samreid samreid closed this as completed Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants