Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCKCQueryParameters.batteryCurrentThreshold remaining reference #888

Closed
jonathanolson opened this issue Jul 19, 2022 · 1 comment
Closed

CCKCQueryParameters.batteryCurrentThreshold remaining reference #888

jonathanolson opened this issue Jul 19, 2022 · 1 comment
Assignees
@samreid

Comments

@jonathanolson
Copy link
Contributor

In LinearTransientAnalysis, it's accessing a query parameter that doesn't exist before (noted to link #245).

I'm adding a ts-ignore for now.
jonathanolson added a commit to phetsims/scenery-phet that referenced this issue Jul 19, 2022
@jonathanolson
Typing of QueryStringMachine in phet-types, see phetsims/chipper#1253 …
fe36293 
…and phetsims/circuit-construction-kit-common#888
jonathanolson added a commit to phetsims/sun that referenced this issue Jul 19, 2022
@jonathanolson
Typing of QueryStringMachine in phet-types, see phetsims/chipper#1253 …
ed2030b 
…and phetsims/circuit-construction-kit-common#888
jonathanolson added a commit to phetsims/vegas that referenced this issue Jul 19, 2022
@jonathanolson
Typing of QueryStringMachine in phet-types, see phetsims/chipper#1253 …
31a649d 
…and phetsims/circuit-construction-kit-common#888
jonathanolson added a commit to phetsims/query-string-machine that referenced this issue Jul 19, 2022
@jonathanolson
Typing QueryStringMachine in phet-types, see phetsims/chipper#1253, p…
d04269a 
…hetsims/circuit-construction-kit-common#888
jonathanolson added a commit to phetsims/chipper that referenced this issue Jul 19, 2022
@jonathanolson
Typing of QueryStringMachine in phet-types, see #1253 and phetsims/ci…
862597f 
…rcuit-construction-kit-common#888
jonathanolson added a commit that referenced this issue Jul 19, 2022
@jonathanolson
Typing QueryStringMachine in phet-types, see phetsims/chipper#1253, #888
48aa551
jonathanolson added a commit to phetsims/geometric-optics that referenced this issue Jul 19, 2022
@jonathanolson
Typing QueryStringMachine in phet-types, see phetsims/chipper#1253, p…
1c3af58 
…hetsims/circuit-construction-kit-common#888
jonathanolson added a commit to phetsims/greenhouse-effect that referenced this issue Jul 19, 2022
@jonathanolson
Typing QueryStringMachine in phet-types, see phetsims/chipper#1253, p…
4463161 
…hetsims/circuit-construction-kit-common#888
jonathanolson added a commit to phetsims/models-of-the-hydrogen-atom that referenced this issue Jul 19, 2022
@jonathanolson
Typing QueryStringMachine in phet-types, see phetsims/chipper#1253, p…
25b6c41 
…hetsims/circuit-construction-kit-common#888
samreid added a commit that referenced this issue Aug 27, 2022
@samreid
Remove unused code, see #888
85200c1
@samreid
Copy link
Member

samreid commented Aug 27, 2022

Fixed, thanks for finding the problem. Closing.

@samreid samreid closed this as completed Aug 27, 2022
samreid pushed a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@jonathanolson
Typing of QueryStringMachine in phet-types, see phetsims/chipper#1253 …
65911c4 
…and phetsims/circuit-construction-kit-common#888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @samreid