The real bulb code looks buggy

[samreid]

From #764, it looks like it is always setting the resistance to 1.0 no matter what. Either something else is at play, or this is very buggy.

    let needsHelp = false;

    resistorAdapters.forEach( resistorAdapter => {
      if ( resistorAdapter.circuitElement instanceof LightBulb && resistorAdapter.circuitElement.real ) {

        // @ts-ignore
        resistorAdapter.resistance = 1.0;
        needsHelp = true;
      }
    } );

[samreid]

It was straightforward to eliminate the awkward-looking code. It seemed mostly safe but should still be checked. I don't think the real bulb appears in AC, so I published a dev version of DC here:

https://phet-dev.colorado.edu/html/circuit-construction-kit-dc/1.3.0-dev.7/phet/circuit-construction-kit-dc_en_phet.html

@arouinfar or @ariel-phet can you please test, and describe how the real bulb can be tested? For reference, here is the issue where we introduced the real bulbs: #10

[ariel-phet]

Will do

[ariel-phet]

@samreid there is an issue with the change you made.

First I compared values to the published sim (resistance, current, voltage) for a simple battery and bulb circuit. All looked correct. However, when the current is removed from the bulb it does not reset its resistance value to the "cold" value. Only when the voltage is explicitly set back to zero does the resistance reset. See the video below for a clear example.

Real.Bulb.mp4

[samreid]

I reverted the change above and was still seeing the buggy behavior, so it must be caused by something else. I'll keep looking.

[samreid]

This problem was introduced when we started excluding "circuit elements that aren't in loops" from the analysis. I added a part for that in the commit.

Can you please test in https://phet-dev.colorado.edu/html/circuit-construction-kit-dc/1.3.0-dev.8/phet/circuit-construction-kit-dc_en_phet.html ? Can you think of other circuit elements that may need another update step like thihs when they are not in a loop?

[ariel-phet]

@samreid issues seem fixed, IV curve looks good. I cannot think of another element like that currently. Closing