Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change socket color for realistic bulb #613

Closed
samreid opened this issue Oct 29, 2020 · 8 comments
Closed

Change socket color for realistic bulb #613

samreid opened this issue Oct 29, 2020 · 8 comments

Comments

@samreid
Copy link
Member

samreid commented Oct 29, 2020

Related to #10. At today's design meeting, we agreed the realistic bulb should look different than the ideal light bulb, and this may be done by drawing the socket differently. High priority since we would like to publish this soon.

@arouinfar
Copy link
Contributor

Here are the bulbs currently in CCK:
image

In design meeting we discussed making the socket a metallic-looking red. Here's a mockup with the coiled filament (see #614). @samreid if this color looks reasonable to you, I'll send you the asset.
lightbulb-3_lightbulb_front_realistic

@samreid
Copy link
Member Author

samreid commented Nov 10, 2020

That seems good to me. Do you want a 2nd opinion from @ariel-phet before we proceed?

@samreid samreid assigned ariel-phet and arouinfar and unassigned samreid Nov 10, 2020
@ariel-phet
Copy link

I like that red color, definitely makes it stand out.

@ariel-phet ariel-phet assigned samreid and unassigned ariel-phet Nov 11, 2020
@arouinfar
Copy link
Contributor

Great, thanks! The final assets will be delivered once we're done iterating on #614.

@samreid samreid removed their assignment Nov 12, 2020
@arouinfar
Copy link
Contributor

arouinfar commented Nov 12, 2020

@samreid the updated assets are linked at the bottom of #614 (comment).

@samreid
Copy link
Member Author

samreid commented Nov 15, 2020

I added the images in the commit. To see them in the toolbar, you might need to remove the pencil (until another issue is fixed). Other than that, can you please review?

UPDATE: On second thought, there is a problem with the socket in the toolbox. Self-reassigning.

@samreid
Copy link
Member Author

samreid commented Nov 15, 2020

OK I think that commit will help. Ready for review.

@samreid samreid assigned arouinfar and unassigned samreid Nov 15, 2020
@arouinfar
Copy link
Contributor

Looks great in master, thanks @samreid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants