-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change socket color for realistic bulb #613
Comments
That seems good to me. Do you want a 2nd opinion from @ariel-phet before we proceed? |
I like that red color, definitely makes it stand out. |
Great, thanks! The final assets will be delivered once we're done iterating on #614. |
@samreid the updated assets are linked at the bottom of #614 (comment). |
I added the images in the commit. To see them in the toolbar, you might need to remove the pencil (until another issue is fixed). Other than that, can you please review? UPDATE: On second thought, there is a problem with the socket in the toolbox. Self-reassigning. |
OK I think that commit will help. Ready for review. |
Looks great in master, thanks @samreid! |
Related to #10. At today's design meeting, we agreed the realistic bulb should look different than the ideal light bulb, and this may be done by drawing the socket differently. High priority since we would like to publish this soon.
The text was updated successfully, but these errors were encountered: