Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we commit debuggers under a query parameter? #989

Closed
zepumph opened this issue Oct 15, 2020 · 2 comments
Closed

Can we commit debuggers under a query parameter? #989

zepumph opened this issue Oct 15, 2020 · 2 comments
Assignees
@zepumph
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Oct 15, 2020

From slack discussion with @samreid, it would be nice to have a ?debugger QP that you can use to get at debuggers throughout the code. Mainly in assert.js, and in qunitStart.
@zepumph zepumph self-assigned this Oct 15, 2020
zepumph added a commit to phetsims/phetmarks that referenced this issue Nov 19, 2020
@zepumph
add debugger query parameter, phetsims/chipper#989
9de506c
zepumph added a commit that referenced this issue Nov 19, 2020
@zepumph
add debugger query parameter, #989
9477f65
zepumph added a commit to phetsims/assert that referenced this issue Nov 19, 2020
@zepumph
add debugger query parameter, phetsims/chipper#989
3df8c5f
@zepumph
Copy link
Member Author

zepumph commented Nov 19, 2020

I added ?debugger. When provided, it will debug on thrown assertion errors and qunit failed tests. @samreid please review.

It looks like debugger is stripped out even for the debug build, so this would only be useful during development.

Here is what assert looked like in the debug version of phet brand friction:

image

@zepumph zepumph assigned samreid and unassigned zepumph Nov 19, 2020
@samreid
Copy link
Member

samreid commented Nov 20, 2020

This looks great to me, I tested throwing an assertion in Gravity and Orbits and it worked as expected. The code changes look good. I would recommend as a final step, adding &debugger to be on by default for phetmarks.

@samreid samreid assigned zepumph and unassigned samreid Nov 20, 2020
@zepumph zepumph closed this as completed Nov 20, 2020
zepumph added a commit to phetsims/phetmarks that referenced this issue Nov 20, 2020
@zepumph
?debugger on by default, phetsims/chipper#989 (comment)
4377819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph