-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chipper/grunt/*.js fails lint #97
Labels
Comments
pixelzoom
added a commit
that referenced
this issue
Feb 11, 2015
pixelzoom
added a commit
that referenced
this issue
Feb 11, 2015
pixelzoom
added a commit
that referenced
this issue
Feb 12, 2015
pixelzoom
added a commit
that referenced
this issue
Feb 12, 2015
Down to 2 lint errors. Some questions about these... Where is '_' being defined before this? Linting grunt/Gruntfile.js ...ERROR
[L18:C5] W079: Redefinition of '_'.
var _ = require( '../../sherpa/lodash-2.4.1.min' ); requirejs is defined but not used anywhere in Gruntfile.js. This is also the subject of #100. Is this vestigial? Or is it actually doing something? If it's doing something, does it need to be assigned to requirejs, or is the call to require sufficient? Linting grunt/Gruntfile.js ...ERROR
[L84:C16] W098: 'requirejs' is defined but never used.
var requirejs = require( '../../' + pkg.name + '/node_modules/requirejs' );
Linting requirejs-plugins/string.js ...ERROR |
pixelzoom
added a commit
that referenced
this issue
Feb 12, 2015
All lint errors fixed. Closing. |
pixelzoom
added a commit
that referenced
this issue
Feb 12, 2015
pixelzoom
added a commit
that referenced
this issue
Feb 12, 2015
pixelzoom
added a commit
that referenced
this issue
Feb 12, 2015
jonathanolson
pushed a commit
that referenced
this issue
Feb 18, 2015
jonathanolson
pushed a commit
that referenced
this issue
Feb 18, 2015
jonathanolson
pushed a commit
that referenced
this issue
Feb 18, 2015
jonathanolson
pushed a commit
that referenced
this issue
Feb 18, 2015
jonathanolson
pushed a commit
that referenced
this issue
Feb 18, 2015
jonathanolson
pushed a commit
that referenced
this issue
Feb 18, 2015
jonathanolson
pushed a commit
that referenced
this issue
Feb 18, 2015
jonathanolson
pushed a commit
that referenced
this issue
Feb 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tested by changing line 147 of chipper/grunt/Gruntfile.js to:
then running
grunt lint
.The text was updated successfully, but these errors were encountered: