-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requirejs still a dev dependency in some package.json files #920
Comments
3 repos (chipper, phet-io-wrappers, studio) have this in package.json. I have no idea whether this is vestigial, is still a dependency, or is a dependency that needs to be removed.
All repos have something like this in package.json. If the namespace is still needed, it should probably be renamed to something other than "requirejsNamespace".
|
@jonathanolson said he can handle this issue (consult with @chrisklus if you have iO related questions). |
Marking as high priority as we would like to clean up ES-6 modules issues in a timely manner |
Verified it was OK to remove, and removed in the above commits.
That's the best name we have for it, since it's specifically to work with how we USED to handle string keys. Should that be tagged for dev meeting discussion? I recall others feeling that it wasn't the best name also. |
Verified that It doesn't look like |
Correct, I mentioned:
Proactively tagging this for developer meeting, so we can discuss. |
Sorry, I somehow missed that. I'm OK with leaving it as "requirejsNamespace". |
I think that universally these shouldn't be needed, but I thought I would check with everyone before deleting.
Found in the above repos'
package.json
file.The text was updated successfully, but these errors were encountered: