Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get aqua passing for es6 modules #874

Closed
jonathanolson opened this issue Feb 6, 2020 · 6 comments
Closed

Get aqua passing for es6 modules #874

jonathanolson opened this issue Feb 6, 2020 · 6 comments
Assignees
@samreid
Labels
chipper:es6-modules

Comments

@jonathanolson
Copy link
Contributor

From the planning doc:

(SR, JG 6 hours?) [pre-publication, sprintable] Get Aqua passing for compilation-free mode for all sims.
SR: Many are failing due to the race condition mentioned in #843. Others are failing from miscellaneous parts that haven’t been migrated correctly or fully.
@jessegreenberg
Copy link
Contributor

It looks like #843 has been resolved.

@Denz1994 Denz1994 assigned samreid and unassigned samreid Feb 20, 2020
@samreid
Copy link
Member

samreid commented Feb 21, 2020

Here's a snapshot of the first page of local aqua:

image

samreid added a commit that referenced this issue Feb 21, 2020
@samreid
generateDevelopmentHTML for sims that already had one, see #874
262bfc6
samreid added a commit that referenced this issue Feb 21, 2020
@samreid
Rename *.jpg, see #874
f13771f
samreid added a commit that referenced this issue Feb 21, 2020
@samreid
Add support for .cur and eliminate mipmap options, see #874
6e06647
samreid added a commit to phetsims/circuit-construction-kit-dc-virtual-lab that referenced this issue Feb 21, 2020
@samreid
Fix namespace, see phetsims/chipper#874
d37ab2f
samreid added a commit to phetsims/energy-skate-park that referenced this issue Feb 21, 2020
@samreid
Apply PhET formatting to assist in ES6 module migration, see phetsims…
7d1fa72 
…/chipper#874
samreid added a commit to phetsims/expression-exchange that referenced this issue Feb 21, 2020
@samreid
Apply PhET formatting to assist in ES6 module migration, see phetsims…
f4579db 
…/chipper#874
@samreid samreid mentioned this issue Feb 21, 2020
Closed
samreid added a commit to phetsims/forces-and-motion-basics that referenced this issue Feb 21, 2020
@samreid
Omit mipmap level option, see phetsims/chipper#874
98ec671
samreid added a commit to phetsims/vibe that referenced this issue Feb 21, 2020
@samreid
Move require statement to top-level, see phetsims/chipper#874
723e835
@samreid
Copy link
Member

samreid commented Feb 21, 2020

Everything is passing except for a string problem in density and buoyancy.

@jonathanolson
Copy link
Contributor Author

I believe this was fixed in density-buoyancy-common master. Can this be closed then, or do we re-run right before migrate?

@samreid
Copy link
Member

samreid commented Feb 21, 2020

Ideally we would re-run after any significant changes, and also again right before migrate in case any untested changes creep in. Nothing to do for now, so I'll remove the label?

@samreid
Copy link
Member

samreid commented Feb 24, 2020

I added this as a pre-migrate step, closing.

@samreid samreid closed this as completed Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
chipper:es6-modules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonathanolson @samreid @jessegreenberg