-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
string plugin getWithCache
doesn't really cache that much
#797
Comments
Above I added a way to cache the intermediary state before the first loading of a string file. I'm pretty happy with this change. It is simple, and is a definite improvement in my book. @samreid can you please review. |
This looks great and looks like it cures the symptoms described in #730. Some questions and comments:
|
Thanks! I really like the suggestions. How's that? |
Looks great, thanks! I'm ready to close if you are. |
While working on phetsims/rosetta#193, I found that almost every string being required from the sim was triggering a loading of the string file. I think this is because all the require loads occur before the text plugin has async come back with the JSON.
A good way to test this problem is to put
console.log('url')
in the text.get() callback.The text was updated successfully, but these errors were encountered: