Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support reportUnusedStrings for nested a11y strings #780

Closed
zepumph opened this issue Jul 22, 2019 · 2 comments
Closed

support reportUnusedStrings for nested a11y strings #780

zepumph opened this issue Jul 22, 2019 · 2 comments
Assignees
@samreid
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Jul 22, 2019

From phetsims/rosetta#193. This is an important piece of the build process, and we should get it working with the new nested strings under the a11y key. Promoting todo.
@zepumph zepumph self-assigned this Jul 22, 2019
zepumph added a commit that referenced this issue Jul 22, 2019
@zepumph
promote TODO, #780
e504e09
zepumph added a commit that referenced this issue Jul 23, 2019
@zepumph
add a11y nested strings support to reportUnusedStrings, #780
2083eb8
zepumph added a commit that referenced this issue Jul 23, 2019
@zepumph
don't reportUnusedStrings for a11y, #780
6123081
zepumph added a commit to phetsims/friction that referenced this issue Jul 23, 2019
@zepumph
remove unused a11y strings from friction, phetsims/chipper#780
d21f02d
@zepumph zepumph removed their assignment Jul 23, 2019
@zepumph
Copy link
Member Author

zepumph commented Jul 23, 2019

This has been implemented, and should be reviewed as part of phetsims/rosetta#193

@zepumph zepumph mentioned this issue Aug 6, 2019
Closed
10 tasks
@samreid samreid self-assigned this Sep 23, 2019
@samreid
Copy link
Member

samreid commented Sep 23, 2019

@zepumph and I reviewed this together and agreed it looks good, thanks! Closing.

@samreid samreid closed this as completed Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph