Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to support dangling spaces for a11y strings #779

Closed
zepumph opened this issue Jul 22, 2019 · 2 comments
Closed

Need to support dangling spaces for a11y strings #779

zepumph opened this issue Jul 22, 2019 · 2 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Jul 22, 2019

From a11y string conversion in phetsims/rosetta#193.

We have some strings that purposefully end/begin in spaces. Currently this feature is only on a branch, but there should be an issue devoted towards fixing this. Right now the string plugin will trim the strings for us.

zepumph added a commit that referenced this issue Jul 22, 2019
@zepumph zepumph self-assigned this Jul 22, 2019
@zepumph
Copy link
Member Author

zepumph commented Jul 22, 2019

The first thought I have here is perhaps we should make these purposeful spaces a special char, maybe a unicode space that trim doesn't strip out.

@zepumph
Copy link
Member Author

zepumph commented Aug 6, 2019

It would be good to note #619 in this discussion, since that issue is why trim calls were added.

@samreid and I discussed and we expect that this constraint will be easy enough to get around by rethinking the template strings. After reading in #619 I think it is not worth trying to support this. Over in phetsims/rosetta#193 we will make sure that when a11y strings are moved into json files, that they are audited for dangling white space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant