-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XHTML path changes #744
Comments
This change creates no issues for me. |
I recall a conversation about this, and there were several constraints on the naming, but I cannot find a paper trail for it in GitHub issues or dev meeting minutes. Maybe @mattpen remembers? One constraint was regarding names served from the website (I think). |
I don't recall any discussion of this point. There is no code in the PhET project that depends on this though.
The only thing I could find was this issue: #706, which is lacking in discussion. It looks like it was already solved and if it is not happening there is probably a regression. I remember deciding this though, as our current practice is to strip the brand from any PhET brand production filenames. |
From 3/14/19 dev meeting: @jonathanolson is going to make this change. |
@jonathanolson - These 3 simulations will need release that supports both old and new naming. After we deliver new names, we can ask client when we can drop support for the old names from these 3 sims. |
Finished the maintenance release for this, closing. |
I believe we discussed the changes for xhtml (ePUB-compatible) links in production builds as the following changes:
.html
suffix to.xhtml
_phet
from the HTML on the build-server/website side of things (like how we do this for top-level HTML files).Can we confirm that this works for developers, AND that vendors have switched to hard-versioned links?
The text was updated successfully, but these errors were encountered: