Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XHTML path changes #744

Closed
jonathanolson opened this issue Feb 27, 2019 · 6 comments
Closed

XHTML path changes #744

jonathanolson opened this issue Feb 27, 2019 · 6 comments
Assignees

Comments

@jonathanolson
Copy link
Contributor

I believe we discussed the changes for xhtml (ePUB-compatible) links in production builds as the following changes:

  1. Change the .html suffix to .xhtml
  2. Strip the _phet from the HTML on the build-server/website side of things (like how we do this for top-level HTML files).

Can we confirm that this works for developers, AND that vendors have switched to hard-versioned links?

@pixelzoom
Copy link
Contributor

This change creates no issues for me.

@samreid
Copy link
Member

samreid commented Mar 7, 2019

I recall a conversation about this, and there were several constraints on the naming, but I cannot find a paper trail for it in GitHub issues or dev meeting minutes. Maybe @mattpen remembers? One constraint was regarding names served from the website (I think).

@mattpen
Copy link
Contributor

mattpen commented Mar 7, 2019

  1. Change the .html suffix to .xhtml

I don't recall any discussion of this point. There is no code in the PhET project that depends on this though.

  1. Strip the _phet from the HTML on the build-server/website side of things (like how we do this for top-level HTML files).

The only thing I could find was this issue: #706, which is lacking in discussion. It looks like it was already solved and if it is not happening there is probably a regression. I remember deciding this though, as our current practice is to strip the brand from any PhET brand production filenames.

@chrisklus
Copy link
Contributor

From 3/14/19 dev meeting:

@jonathanolson is going to make this change.

@kathy-phet
Copy link

@jonathanolson - These 3 simulations will need release that supports both old and new naming.
Reactants, Products, and Leftovers: https://phet.colorado.edu/sims/html/reactants-products-and-leftovers/latest/xhtml/reactants-products-and-leftovers_all_phet.html
Molarity: https://phet.colorado.edu/sims/html/molarity/latest/xhtml/molarity_all_phet.html
States of Matter: https://phet.colorado.edu/sims/html/states-of-matter/latest/xhtml/states-of-matter_all_phet.html?screens=1

After we deliver new names, we can ask client when we can drop support for the old names from these 3 sims.

jonathanolson added a commit to phetsims/phetmarks that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 28, 2019
jonathanolson added a commit that referenced this issue Mar 29, 2019
jonathanolson added a commit to phetsims/area-model-algebra that referenced this issue Mar 29, 2019
jonathanolson added a commit to phetsims/area-model-decimals that referenced this issue Mar 29, 2019
jonathanolson added a commit to phetsims/area-model-introduction that referenced this issue Mar 29, 2019
jonathanolson added a commit that referenced this issue Mar 29, 2019
jonathanolson added a commit to phetsims/area-model-multiplication that referenced this issue Mar 29, 2019
jonathanolson added a commit that referenced this issue Mar 29, 2019
jonathanolson added a commit to phetsims/energy-forms-and-changes that referenced this issue Mar 29, 2019
jonathanolson added a commit that referenced this issue Mar 29, 2019
jonathanolson added a commit that referenced this issue Mar 29, 2019
jonathanolson added a commit to phetsims/molecule-shapes that referenced this issue Mar 29, 2019
jonathanolson added a commit that referenced this issue Mar 29, 2019
jonathanolson added a commit to phetsims/molecule-shapes-basics that referenced this issue Mar 29, 2019
jonathanolson added a commit that referenced this issue Mar 29, 2019
jonathanolson added a commit to phetsims/states-of-matter-basics that referenced this issue Mar 29, 2019
@jonathanolson
Copy link
Contributor Author

Finished the maintenance release for this, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants