Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for sim-a11y-view.html template #658

Closed
4 tasks done
samreid opened this issue Feb 13, 2018 · 1 comment
Closed
4 tasks done

Improvements for sim-a11y-view.html template #658

samreid opened this issue Feb 13, 2018 · 1 comment
Assignees

Comments

@samreid
Copy link
Member

samreid commented Feb 13, 2018

I noticed a few issues in the sim-a11y-view.html template. I'll mark them here as checkboxes, then assign to @jessegreenberg for work. After the work is complete, the actual sim a11y HTMLs should be regenerated and committed. This was discovered during phetsims/friction#64

  • Typo in ineficient
  • intervalId is never assigned to a var, and hence is getting assigned to window as a global.
  • typo in the last word in this phrase: // set focus to the loaded ifram
  • variable is never used: var politeElementContainer = document.getElementById( 'polite-element-container' );
@samreid samreid assigned samreid and jessegreenberg and unassigned samreid Feb 13, 2018
jessegreenberg added a commit that referenced this issue Mar 2, 2018
jessegreenberg added a commit that referenced this issue Mar 2, 2018
jessegreenberg added a commit that referenced this issue Mar 2, 2018
@jessegreenberg
Copy link
Contributor

Thanks @samreid, fixes made in the above commits. I regenerated a11y views with
perennial/bin/for-each.sh accessibility grunt generate-a11y-view-html and pushed. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants