Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting of generated qunit htmls. #634

Closed
samreid opened this issue Dec 7, 2017 · 6 comments
Closed

Fix formatting of generated qunit htmls. #634

samreid opened this issue Dec 7, 2017 · 6 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Dec 7, 2017

See #631

just generate the file with the correct formatting in the first place (so that Intellij wouldn't change it in your commit step).

@samreid
Copy link
Member Author

samreid commented Dec 13, 2017

I'm inclined to work on this after chipper 2.0 goes to master, putting on hold until then.

samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Jan 22, 2018
@samreid
Copy link
Member Author

samreid commented Jan 22, 2018

I'm using CCK-DC as a guinea pig for tinkering with the formatting.

samreid added a commit that referenced this issue Jan 22, 2018
@samreid
Copy link
Member Author

samreid commented Jan 22, 2018

After the above commit, grunt generate-development-html and grunt generate-test-html HTMLs are generated with the proper IDEA formatting, so that IDEA formatting does nothing. I'll iterate over all projects to update their HTMLs using:

for-each.sh active-runnables grunt generate-development-html

And I'll update the test htmls manually, since only a handful of sims have test HTML at the moment.

@samreid
Copy link
Member Author

samreid commented Jan 22, 2018

I spot checked several files, verified formatting is correct and that nothing else has changed. Aqua looks clear. Expression exchange is launching, linting, building and launching/built. Same with equality explorer. Hence, I'll commit. Brace yourselves for multi-repo commit.

samreid added a commit to phetsims/circuit-construction-kit-black-box-study that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/circuit-construction-kit-dc-virtual-lab that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/reactants-products-and-leftovers that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/balloons-and-static-electricity that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/balancing-chemical-equations that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/models-of-the-hydrogen-atom that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/gene-expression-essentials that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/area-model-multiplication that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/gravity-force-lab-basics that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/isotopes-and-atomic-mass that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/least-squares-regression that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/energy-forms-and-changes that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/energy-skate-park-basics that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/forces-and-motion-basics that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/graphing-slope-intercept that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/sugar-and-salt-solutions that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/fluid-pressure-and-flow that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/states-of-matter-basics that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/function-builder-basics that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/molecule-shapes-basics that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/hookes-law that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/arithmetic that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/make-a-ten that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/estimation that referenced this issue Jan 22, 2018
samreid added a commit to phetsims/trig-tour that referenced this issue Jan 22, 2018
@samreid
Copy link
Member Author

samreid commented Jan 22, 2018

Bayes confirms all is clear. Last step is to regenerate test HTMLs.

@samreid
Copy link
Member Author

samreid commented Jan 22, 2018

All fixed except for 2 newly discovered problems, noted above, closing.

@samreid samreid closed this as completed Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant