Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove hidden attribute from aria-live elements #544

Closed
jessegreenberg opened this issue Feb 7, 2017 · 1 comment
Closed

remove hidden attribute from aria-live elements #544

jessegreenberg opened this issue Feb 7, 2017 · 1 comment
Assignees
@jessegreenberg

Comments

@jessegreenberg
Copy link
Contributor

It is not necessary, and only forces clients to explicitly unhide elements when they want an accessible alert. When we created the group of aria-live elements initially, we hoped that hiding the group of elements would prevent NVDA from reading "alert" on sim startup. NVDA reads this regardless, so the hidden attribute should be removed.
@jessegreenberg jessegreenberg self-assigned this Feb 7, 2017
jessegreenberg added a commit to phetsims/area-builder that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
81bd5c2 
…#544
jessegreenberg added a commit to phetsims/area-model-multiplication that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
46abcf5 
…#544
jessegreenberg added a commit to phetsims/arithmetic that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
306e11a 
…#544
jessegreenberg added a commit to phetsims/atomic-interactions that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
7ec07b4 
…#544
jessegreenberg added a commit to phetsims/balancing-act that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
e988bbc 
…#544
jessegreenberg added a commit to phetsims/balancing-chemical-equations that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
71cf2dc 
…#544
jessegreenberg added a commit to phetsims/balloons-and-static-electricity that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
c705638 
…#544
jessegreenberg added a commit to phetsims/beers-law-lab that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
df8093b 
…#544
jessegreenberg added a commit to phetsims/bending-light that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
13c03b0 
…#544
jessegreenberg added a commit to phetsims/blast that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
4cd4847 
…#544
jessegreenberg added a commit to phetsims/wave-on-a-string that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
4caebbd 
…#544
jessegreenberg added a commit to phetsims/build-a-molecule that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
88f38b4 
…#544
jessegreenberg added a commit to phetsims/build-an-atom that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
fed1c4e 
…#544
jessegreenberg added a commit to phetsims/calculus-grapher that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
57e8d91 
…#544
jessegreenberg added a commit to phetsims/capacitor-lab-basics that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
c0f77ad 
…#544
jessegreenberg added a commit to phetsims/chains that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
22740ac 
…#544
jessegreenberg added a commit to phetsims/charges-and-fields that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
320107d 
…#544
jessegreenberg added a commit to phetsims/circuit-construction-kit-black-box-study that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
c2bce99 
…#544
jessegreenberg added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
e92cfe9 
…#544
jessegreenberg added a commit to phetsims/color-vision that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
3fe08c1 
…#544
jessegreenberg added a commit to phetsims/concentration that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
0648d81 
…#544
jessegreenberg added a commit to phetsims/curve-fitting that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
51300dd 
…#544
jessegreenberg added a commit to phetsims/energy-forms-and-changes that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
98c6d0e 
…#544
jessegreenberg added a commit to phetsims/energy-skate-park-basics that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
046828a 
…#544
jessegreenberg added a commit to phetsims/estimation that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
52ac2c8 
…#544
jessegreenberg added a commit to phetsims/example-sim that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
791d36c 
…#544
jessegreenberg added a commit to phetsims/faradays-law that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
994fbb5 
…#544
jessegreenberg added a commit to phetsims/fluid-pressure-and-flow that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
791540a 
…#544
jessegreenberg added a commit to phetsims/forces-and-motion-basics that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
8b4f894 
…#544
jessegreenberg added a commit to phetsims/states-of-matter that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
6ada47d 
…#544
jessegreenberg added a commit to phetsims/states-of-matter-basics that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
ffc6ccb 
…#544
jessegreenberg added a commit to phetsims/sun that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
3cb738d 
…#544
jessegreenberg added a commit to phetsims/trig-tour that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
3531df1 
…#544
jessegreenberg added a commit to phetsims/under-pressure that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
d43001c 
…#544
jessegreenberg added a commit to phetsims/unit-rates that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
70472e9 
…#544
jessegreenberg added a commit to phetsims/vegas that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
1531c6d 
…#544
jessegreenberg added a commit to phetsims/vibe that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
549baf5 
…#544
jessegreenberg added a commit to phetsims/expression-exchange that referenced this issue Feb 7, 2017
@jessegreenberg
remove hidden attribute from aria-live elements, see phetsims/chipper…
2b467ee 
…#544
@jessegreenberg
Copy link
Contributor Author

Done, closing.

43Meister added a commit to 43Meister/HCI_Web7 that referenced this issue Feb 24, 2023
@43Meister
remove hidden attribute from aria-live elements, see phetsims/chipper…
4955eaf 
…#544
Alejanpro added a commit to Alejanpro/InitialFlutter that referenced this issue Feb 24, 2023
@Alejanpro
remove hidden attribute from aria-live elements, see phetsims/chipper…
5bc8fed 
…#544
RitoNQ added a commit to RitoNQ/radius that referenced this issue Mar 3, 2023
@RitoNQ
remove hidden attribute from aria-live elements, see phetsims/chipper…
349e20f 
…#544
Wangsimg added a commit to Wangsimg/untibunti that referenced this issue Mar 8, 2023
@Wangsimg
remove hidden attribute from aria-live elements, see phetsims/chipper…
663bdc5 
…#544
yuweny1 added a commit to yuweny1/CPTS440 that referenced this issue Mar 10, 2023
@yuweny1
remove hidden attribute from aria-live elements, see phetsims/chipper…
4f802f0 
…#544
Ukililee added a commit to Ukililee/web-components-sample-202001 that referenced this issue Mar 19, 2023
@Ukililee
remove hidden attribute from aria-live elements, see phetsims/chipper…
fdc6875 
…#544
nsfwow added a commit to nsfwow/devopsgitclass that referenced this issue Apr 24, 2023
@nsfwow
remove hidden attribute from aria-live elements, see phetsims/chipper…
3ef43b1 
…#544
mumusia added a commit to mumusia/ATLASBACKUPPER that referenced this issue Apr 24, 2023
@mumusia
remove hidden attribute from aria-live elements, see phetsims/chipper…
49a1dea 
…#544
DTAstack added a commit to DTAstack/-o-Hi-u- that referenced this issue Apr 24, 2023
@DTAstack
remove hidden attribute from aria-live elements, see phetsims/chipper…
ce8d001 
…#544
dighumcld added a commit to dighumcld/tiny-graphics-assignments9 that referenced this issue May 6, 2023
@dighumcld
remove hidden attribute from aria-live elements, see phetsims/chipper…
121347d 
…#544
cimashiro added a commit to cimashiro/-Awesome-CVE-2020-0601- that referenced this issue May 7, 2023
@cimashiro
remove hidden attribute from aria-live elements, see phetsims/chipper…
12971ab 
…#544
cimashiro added a commit to cimashiro/-Awesome-CVE-2020-0601- that referenced this issue May 7, 2023
@cimashiro
remove hidden attribute from aria-live elements, see phetsims/chipper…
ba9dd50 
…#544
Dzzit added a commit to Dzzit/ReverseIPLookup that referenced this issue May 10, 2023
@Dzzit
remove hidden attribute from aria-live elements, see phetsims/chipper…
add1108 
…#544
Nebulale added a commit to Nebulale/Film-Site- that referenced this issue Jun 6, 2023
@Nebulale
remove hidden attribute from aria-live elements, see phetsims/chipper…
43b0e1b 
…#544
AquaSecure added a commit to AquaSecure/ExperimentalNlpWithPoems that referenced this issue Nov 14, 2023
@AquaSecure
remove hidden attribute from aria-live elements, see phetsims/chipper…
a9ce576 
…#544
JavaArtisan added a commit to JavaArtisan/VisionDeepLearningFundamentals that referenced this issue Dec 6, 2023
@JavaArtisan
remove hidden attribute from aria-live elements, see phetsims/chipper…
24c5926 
…#544
maskone66 added a commit to maskone66/Genetics-Enhanced_LSTM that referenced this issue Jun 3, 2024
@maskone66
remove hidden attribute from aria-live elements, see phetsims/chipper…
bbb006d 
…#544
rusthigh added a commit to rusthigh/optimized-chat-interface that referenced this issue Aug 30, 2024
@rusthigh
remove hidden attribute from aria-live elements, see phetsims/chipper…
5f0a6d5 
…#544
onlybranch added a commit to onlybranch/neurips-bert-brain-2019 that referenced this issue Sep 7, 2024
@onlybranch
remove hidden attribute from aria-live elements, see phetsims/chipper…
e461e69 
…#544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessegreenberg