-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grunt-eslint #495
Comments
I've updated all package.json locally, and running npm install and grunt lint-all to catch errors. If all is well, I'll commit everything. Afterwards, developers will need pull and |
OK lint is looking good everywhere, catching only errors that should be caught. I checked that the new lint is still using our custom rules. Committing shortly. |
OK all changes are pushed and all repos are using eslint ~19.0.0. Developers will need pull and @jonathanolson can you npm install everywhere on phet-server? |
I believe @jbphet or @mattpen may have taken care of this in the 'npm update' task? |
With the recent modifications, the build server should pull master and run |
My mistake, I think I was referring to test-server, and I believe @jonathanolson has already taken care of that. |
19.0.0 was updated recently, with the following fixes:
The new lint started catching issues like "unreachable code" and "Unexpected control character(s) in regular expression"
The text was updated successfully, but these errors were encountered: