Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grunt-eslint #495

Closed
samreid opened this issue Sep 24, 2016 · 6 comments
Closed

Update grunt-eslint #495

samreid opened this issue Sep 24, 2016 · 6 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Sep 24, 2016

19.0.0 was updated recently, with the following fixes:

  • added maxWarnings option
  • don't log newline when no output
  • updated eslint to ^3.0.0
  • don't error out when there are no files to lint

The new lint started catching issues like "unreachable code" and "Unexpected control character(s) in regular expression"

@samreid samreid self-assigned this Sep 24, 2016
@samreid
Copy link
Member Author

samreid commented Sep 24, 2016

I've updated all package.json locally, and running npm install and grunt lint-all to catch errors. If all is well, I'll commit everything. Afterwards, developers will need pull and npm install for each simulation, and update their local ESLint to latest (3.0.0 series).

@samreid
Copy link
Member Author

samreid commented Sep 24, 2016

OK lint is looking good everywhere, catching only errors that should be caught. I checked that the new lint is still using our custom rules. Committing shortly.

samreid added a commit to phetsims/curve-fitting that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/query-string-machine that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/dot that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/energy-skate-park-basics that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/estimation that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/example-sim that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/forces-and-motion-basics that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/fluid-pressure-and-flow that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/fraction-comparison that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/fraction-matcher that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/function-builder that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/graphing-lines that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/gravity-and-orbits that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/graphing-quadratics that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/gravity-force-lab that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/griddle that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/isotopes-and-atomic-mass that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/hookes-law that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/john-travoltage that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/joist that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/least-squares-regression that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/kite that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/masses-and-springs that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/make-a-ten that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/mobius that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/molarity that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/models-of-the-hydrogen-atom that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/circuit-construction-kit-basics that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/circuit-construction-kit-black-box-study that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/gene-expression-essentials that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/area-model-multiplication that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/color-vision that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/gravity-force-lab-basics that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/concentration that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/energy-forms-and-changes that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/expression-exchange that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/faradays-law that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/friction that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/perennial that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/rosetta that referenced this issue Sep 24, 2016
samreid added a commit to phetsims/states-of-matter that referenced this issue Sep 24, 2016
@samreid
Copy link
Member Author

samreid commented Sep 24, 2016

OK all changes are pushed and all repos are using eslint ~19.0.0.

Developers will need pull and npm install for each simulation, and update their local ESLint to latest (3.0.0 series).

@jonathanolson can you npm install everywhere on phet-server?

@samreid samreid assigned jonathanolson and unassigned samreid Sep 24, 2016
schmitzware pushed a commit to phetsims/unit-rates that referenced this issue Sep 26, 2016
@jonathanolson
Copy link
Contributor

@jonathanolson can you npm install everywhere on phet-server?

I believe @jbphet or @mattpen may have taken care of this in the 'npm update' task?

@jonathanolson jonathanolson assigned jbphet and mattpen and unassigned jonathanolson Oct 6, 2016
@jbphet
Copy link
Contributor

jbphet commented Oct 6, 2016

With the recent modifications, the build server should pull master and run npm prune and npm update for chipper, perennial, and the sim that is being built at the beginning of the build process. So, unless I'm missing something, I don't think any manual steps should be needed. Back to @samreid to say whether he thinks that the manual update really is required for some reason.

@jbphet jbphet assigned samreid and unassigned jbphet and mattpen Oct 6, 2016
@samreid
Copy link
Member Author

samreid commented Oct 7, 2016

My mistake, I think I was referring to test-server, and I believe @jonathanolson has already taken care of that.

@samreid samreid closed this as completed Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants